From: ithamar.adema@team-embedded.nl (Ithamar R. Adema)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/9] lpc2k: multifunction pin configuration
Date: Fri, 18 Mar 2011 20:55:29 +0100 [thread overview]
Message-ID: <1300478129.2138.172.camel@team-embedded-2> (raw)
In-Reply-To: <083DF309106F364B939360100EC290F80B15C9BD62@eu1rdcrdc1wx030.exi.nxp.com>
Hi Kevin,
On Fri, 2011-03-18 at 18:42 +0100, Kevin Wells wrote:
[...]
> would be something like:
> #define PGPIO(x, y) (((x) * 32) + (y))
> #define GPIO0_RD1 MFP_CFG(PGPIO(0, 0), AF1)
> #define GPIO33_ENET_TXD1 MFP_CFG(PGPIO(1, 1), AF1)
I've introduced an LPC2K_GPIO(port,pin) macro for that, and already use
it for the IRQs too. I like your suggestion!
However, since now we're not using explicit GPIO numbers anymore,
wouldn't you agree it would be better to make the above:
#define P0_0_RD1 MFP_CFG(LPC2K_GPIO(0, 0), AF1)
instead of still using the GPIOx prefix?
Regards,
Ithamar.
next prev parent reply other threads:[~2011-03-18 19:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 15:11 [PATCH v2 0/9] Support for NXP LPC2K SoCs Ithamar R. Adema
2011-03-18 15:11 ` [PATCH v2 1/9] lpc2k: Core support Ithamar R. Adema
2011-03-18 15:27 ` Russell King - ARM Linux
2011-03-18 15:42 ` Ithamar R. Adema
2011-03-18 15:11 ` [PATCH v2 2/9] lpc2k: Exception vector handling Ithamar R. Adema
2011-03-18 15:16 ` Russell King - ARM Linux
2011-03-18 17:06 ` Ithamar R. Adema
2011-03-18 15:11 ` [PATCH v2 3/9] lpc2k: clk API Ithamar R. Adema
2011-03-18 15:11 ` [PATCH v2 4/9] lpc2k: generic time and clockevents Ithamar R. Adema
2011-03-18 15:20 ` Russell King - ARM Linux
2011-03-18 15:44 ` Ithamar R. Adema
2011-03-18 17:15 ` Kevin Wells
2011-03-18 18:32 ` Ithamar R. Adema
2011-03-18 15:11 ` [PATCH v2 5/9] lpc2k: gpiolib Ithamar R. Adema
2011-03-18 15:11 ` [PATCH v2 6/9] lpc2k: multifunction pin configuration Ithamar R. Adema
2011-03-18 17:42 ` Kevin Wells
2011-03-18 19:55 ` Ithamar R. Adema [this message]
2011-03-18 15:11 ` [PATCH v2 7/9] lpc2k: Add EmbeddedArtists LPC2478 Developer's Kit board Ithamar R. Adema
2011-03-18 15:21 ` Russell King - ARM Linux
2011-03-18 15:54 ` Ithamar R. Adema
2011-03-18 15:11 ` [PATCH v2 8/9] lpc2k: Add UART, SSP, and MCI devices Ithamar R. Adema
2011-03-18 15:11 ` [PATCH v2 9/9] lpc2k: defconfig for NXP LPC2K platform Ithamar R. Adema
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300478129.2138.172.camel@team-embedded-2 \
--to=ithamar.adema@team-embedded.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).