* arm: Move the definition of ARCH_HAS_DMA_MMAP_COHERENT where it belongs
@ 2011-03-25 6:47 Benjamin Herrenschmidt
2011-03-25 8:02 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2011-03-25 6:47 UTC (permalink / raw)
To: linux-arm-kernel
Something I noticed while implementing dma_mmap_coherent() for powerpc...
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
arch/arm/include/asm/dma-mapping.h | 2 +-
sound/core/pcm_native.c | 7 -------
2 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
index 4fff837..ed33eab 100644
--- a/arch/arm/include/asm/dma-mapping.h
+++ b/arch/arm/include/asm/dma-mapping.h
@@ -214,7 +214,7 @@ extern void dma_free_coherent(struct device *, size_t, void *, dma_addr_t);
*/
int dma_mmap_coherent(struct device *, struct vm_area_struct *,
void *, dma_addr_t, size_t);
-
+#define ARCH_HAS_DMA_MMAP_COHERENT
/**
* dma_alloc_writecombine - allocate writecombining memory for DMA
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index ae42b65..2d99c37 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -3145,13 +3145,6 @@ static const struct vm_operations_struct snd_pcm_vm_ops_data_fault = {
.fault = snd_pcm_mmap_data_fault,
};
-#ifndef ARCH_HAS_DMA_MMAP_COHERENT
-/* This should be defined / handled globally! */
-#ifdef CONFIG_ARM
-#define ARCH_HAS_DMA_MMAP_COHERENT
-#endif
-#endif
-
/*
* mmap the DMA buffer on RAM
*/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* arm: Move the definition of ARCH_HAS_DMA_MMAP_COHERENT where it belongs
2011-03-25 6:47 arm: Move the definition of ARCH_HAS_DMA_MMAP_COHERENT where it belongs Benjamin Herrenschmidt
@ 2011-03-25 8:02 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2011-03-25 8:02 UTC (permalink / raw)
To: linux-arm-kernel
At Fri, 25 Mar 2011 17:47:50 +1100,
Benjamin Herrenschmidt wrote:
>
> Something I noticed while implementing dma_mmap_coherent() for powerpc...
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Thanks for catching up!
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi
> ---
> arch/arm/include/asm/dma-mapping.h | 2 +-
> sound/core/pcm_native.c | 7 -------
> 2 files changed, 1 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> index 4fff837..ed33eab 100644
> --- a/arch/arm/include/asm/dma-mapping.h
> +++ b/arch/arm/include/asm/dma-mapping.h
> @@ -214,7 +214,7 @@ extern void dma_free_coherent(struct device *, size_t, void *, dma_addr_t);
> */
> int dma_mmap_coherent(struct device *, struct vm_area_struct *,
> void *, dma_addr_t, size_t);
> -
> +#define ARCH_HAS_DMA_MMAP_COHERENT
>
> /**
> * dma_alloc_writecombine - allocate writecombining memory for DMA
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index ae42b65..2d99c37 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -3145,13 +3145,6 @@ static const struct vm_operations_struct snd_pcm_vm_ops_data_fault = {
> .fault = snd_pcm_mmap_data_fault,
> };
>
> -#ifndef ARCH_HAS_DMA_MMAP_COHERENT
> -/* This should be defined / handled globally! */
> -#ifdef CONFIG_ARM
> -#define ARCH_HAS_DMA_MMAP_COHERENT
> -#endif
> -#endif
> -
> /*
> * mmap the DMA buffer on RAM
> */
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-25 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-25 6:47 arm: Move the definition of ARCH_HAS_DMA_MMAP_COHERENT where it belongs Benjamin Herrenschmidt
2011-03-25 8:02 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox