linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rajeev-dlh.kumar@st.com (Rajeev Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH resend] input/spear-keyboard fix: return IRQ_NONE if (status reg & DATA_AVAIL)
Date: Mon, 28 Mar 2011 17:29:06 +0530	[thread overview]
Message-ID: <1301313546-24420-1-git-send-email-rajeev-dlh.kumar@st.com> (raw)

We should return IRQ_NONE from interrupt handler in case data is not
avail for keyboard

Signed-off-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
---
 drivers/input/keyboard/spear-keyboard.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
index f18dc67..c6ab1df 100644
--- a/drivers/input/keyboard/spear-keyboard.c
+++ b/drivers/input/keyboard/spear-keyboard.c
@@ -70,7 +70,7 @@ static irqreturn_t spear_kbd_interrupt(int irq, void *dev_id)
 	u8 sts, val;
 
 	sts = readb(kbd->io_base + STATUS_REG);
-	if (sts & DATA_AVAIL)
+	if (!(sts & DATA_AVAIL))
 		return IRQ_NONE;
 
 	if (kbd->last_key != KEY_RESERVED) {
-- 
1.6.0.2

             reply	other threads:[~2011-03-28 11:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28 11:59 Rajeev Kumar [this message]
2011-03-31  5:34 ` [PATCH resend] input/spear-keyboard fix: return IRQ_NONE if (status reg & DATA_AVAIL) Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301313546-24420-1-git-send-email-rajeev-dlh.kumar@st.com \
    --to=rajeev-dlh.kumar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).