* [PATCH resend] input/spear-keyboard fix: return IRQ_NONE if (status reg & DATA_AVAIL)
@ 2011-03-28 11:59 Rajeev Kumar
2011-03-31 5:34 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Rajeev Kumar @ 2011-03-28 11:59 UTC (permalink / raw)
To: linux-arm-kernel
We should return IRQ_NONE from interrupt handler in case data is not
avail for keyboard
Signed-off-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
---
drivers/input/keyboard/spear-keyboard.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
index f18dc67..c6ab1df 100644
--- a/drivers/input/keyboard/spear-keyboard.c
+++ b/drivers/input/keyboard/spear-keyboard.c
@@ -70,7 +70,7 @@ static irqreturn_t spear_kbd_interrupt(int irq, void *dev_id)
u8 sts, val;
sts = readb(kbd->io_base + STATUS_REG);
- if (sts & DATA_AVAIL)
+ if (!(sts & DATA_AVAIL))
return IRQ_NONE;
if (kbd->last_key != KEY_RESERVED) {
--
1.6.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH resend] input/spear-keyboard fix: return IRQ_NONE if (status reg & DATA_AVAIL)
2011-03-28 11:59 [PATCH resend] input/spear-keyboard fix: return IRQ_NONE if (status reg & DATA_AVAIL) Rajeev Kumar
@ 2011-03-31 5:34 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2011-03-31 5:34 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Mar 28, 2011 at 05:29:06PM +0530, Rajeev Kumar wrote:
> We should return IRQ_NONE from interrupt handler in case data is not
> avail for keyboard
>
Applied, thank you Rajeev.
> Signed-off-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
> ---
> drivers/input/keyboard/spear-keyboard.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
> index f18dc67..c6ab1df 100644
> --- a/drivers/input/keyboard/spear-keyboard.c
> +++ b/drivers/input/keyboard/spear-keyboard.c
> @@ -70,7 +70,7 @@ static irqreturn_t spear_kbd_interrupt(int irq, void *dev_id)
> u8 sts, val;
>
> sts = readb(kbd->io_base + STATUS_REG);
> - if (sts & DATA_AVAIL)
> + if (!(sts & DATA_AVAIL))
> return IRQ_NONE;
>
> if (kbd->last_key != KEY_RESERVED) {
> --
> 1.6.0.2
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-31 5:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 11:59 [PATCH resend] input/spear-keyboard fix: return IRQ_NONE if (status reg & DATA_AVAIL) Rajeev Kumar
2011-03-31 5:34 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).