From: omar.ramirez@ti.com (Omar Ramirez Luna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] OMAP3: l3: fix for "irq 10: nobody cared" message
Date: Tue, 29 Mar 2011 11:20:15 -0600 [thread overview]
Message-ID: <1301419219-30547-2-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1301419219-30547-1-git-send-email-omar.ramirez@ti.com>
If an error occurs in the L3 on any other initiator than MPU,
the interrupt goes unhandled given that the 'base' register
was calculated with the initialized err_source value (which
coincidentally points to MPU) and not with the actual source
of the error.
Removed parenthesis that are not needed for the touched lines.
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
arch/arm/mach-omap2/omap_l3_smx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
index 5f2da75..4321e79 100644
--- a/arch/arm/mach-omap2/omap_l3_smx.c
+++ b/arch/arm/mach-omap2/omap_l3_smx.c
@@ -196,11 +196,11 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
/* No timeout error for debug sources */
}
- base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
-
/* identify the error source */
for (err_source = 0; !(status & (1 << err_source)); err_source++)
;
+
+ base = l3->rt + *(omap3_l3_bases[int_type] + err_source);
error = omap3_l3_readll(base, L3_ERROR_LOG);
if (error) {
--
1.7.1
next prev parent reply other threads:[~2011-03-29 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 17:20 [PATCH 0/5] OMAP: l3: fixes and cleanup Omar Ramirez Luna
2011-03-29 17:20 ` Omar Ramirez Luna [this message]
2011-03-30 6:27 ` [PATCH 1/5] OMAP3: l3: fix for "irq 10: nobody cared" message Santosh Shilimkar
2011-03-29 17:20 ` [PATCH 2/5] OMAP3: l3: fix omap3_l3_probe error path Omar Ramirez Luna
2011-03-30 6:36 ` Santosh Shilimkar
2011-03-29 17:20 ` [PATCH 3/5] OMAP3: l3: minor cleanup for error message, parenthesis and extra lines Omar Ramirez Luna
2011-03-29 17:20 ` [PATCH 4/5] OMAP4: l3: fix omap4_l3_probe error path Omar Ramirez Luna
2011-03-29 17:20 ` [PATCH 5/5] OMAP4: l3: minor cleanup for parenthesis and extra spaces Omar Ramirez Luna
2011-03-30 6:45 ` [PATCH 0/5] OMAP: l3: fixes and cleanup Santosh Shilimkar
2011-03-31 22:05 ` Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301419219-30547-2-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).