* [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'
@ 2011-03-14 14:54 Shawn Guo
2011-03-28 14:38 ` Shawn Guo
2011-03-31 1:31 ` [PATCH] mmc: sdhci: change CONFIG of MMC_SDHCI_TEGRA from 'tristate' to 'bool' Shawn Guo
0 siblings, 2 replies; 7+ messages in thread
From: Shawn Guo @ 2011-03-14 14:54 UTC (permalink / raw)
To: linux-arm-kernel
The MMC_SDHCI based driver is either based on MMC_SDHCI_PLTFM or
MMC_SDHCI_OF. As both parent CONFIG are 'tristate', it may make
sense to get all children drivers CONFIG as 'tristate'.
Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
---
drivers/mmc/host/Kconfig | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index afe8c6f..f98adbf 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -91,7 +91,7 @@ config MMC_SDHCI_OF
If unsure, say N.
config MMC_SDHCI_OF_ESDHC
- bool "SDHCI OF support for the Freescale eSDHC controller"
+ tristate "SDHCI OF support for the Freescale eSDHC controller"
depends on MMC_SDHCI_OF
depends on PPC_OF
select MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER
@@ -101,7 +101,7 @@ config MMC_SDHCI_OF_ESDHC
If unsure, say N.
config MMC_SDHCI_OF_HLWD
- bool "SDHCI OF support for the Nintendo Wii SDHCI controllers"
+ tristate "SDHCI OF support for the Nintendo Wii SDHCI controllers"
depends on MMC_SDHCI_OF
depends on PPC_OF
select MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER
@@ -124,7 +124,7 @@ config MMC_SDHCI_PLTFM
If unsure, say N.
config MMC_SDHCI_CNS3XXX
- bool "SDHCI support on the Cavium Networks CNS3xxx SoC"
+ tristate "SDHCI support on the Cavium Networks CNS3xxx SoC"
depends on ARCH_CNS3XXX
depends on MMC_SDHCI_PLTFM
help
@@ -133,7 +133,7 @@ config MMC_SDHCI_CNS3XXX
If unsure, say N.
config MMC_SDHCI_ESDHC_IMX
- bool "SDHCI platform support for the Freescale eSDHC i.MX controller"
+ tristate "SDHCI platform support for the Freescale eSDHC i.MX controller"
depends on MMC_SDHCI_PLTFM && (ARCH_MX25 || ARCH_MX35 || ARCH_MX5)
select MMC_SDHCI_IO_ACCESSORS
help
@@ -143,7 +143,7 @@ config MMC_SDHCI_ESDHC_IMX
If unsure, say N.
config MMC_SDHCI_DOVE
- bool "SDHCI support on Marvell's Dove SoC"
+ tristate "SDHCI support on Marvell's Dove SoC"
depends on ARCH_DOVE
depends on MMC_SDHCI_PLTFM
select MMC_SDHCI_IO_ACCESSORS
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'
2011-03-14 14:54 [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate' Shawn Guo
@ 2011-03-28 14:38 ` Shawn Guo
2011-03-29 1:57 ` Chris Ball
2011-03-31 1:31 ` [PATCH] mmc: sdhci: change CONFIG of MMC_SDHCI_TEGRA from 'tristate' to 'bool' Shawn Guo
1 sibling, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2011-03-28 14:38 UTC (permalink / raw)
To: linux-arm-kernel
Hi Chris,
Any comment on this one?
--
Regards,
Shawn
On Mon, Mar 14, 2011 at 10:54:25PM +0800, Shawn Guo wrote:
> The MMC_SDHCI based driver is either based on MMC_SDHCI_PLTFM or
> MMC_SDHCI_OF. As both parent CONFIG are 'tristate', it may make
> sense to get all children drivers CONFIG as 'tristate'.
>
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> ---
> drivers/mmc/host/Kconfig | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index afe8c6f..f98adbf 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -91,7 +91,7 @@ config MMC_SDHCI_OF
> If unsure, say N.
>
> config MMC_SDHCI_OF_ESDHC
> - bool "SDHCI OF support for the Freescale eSDHC controller"
> + tristate "SDHCI OF support for the Freescale eSDHC controller"
> depends on MMC_SDHCI_OF
> depends on PPC_OF
> select MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER
> @@ -101,7 +101,7 @@ config MMC_SDHCI_OF_ESDHC
> If unsure, say N.
>
> config MMC_SDHCI_OF_HLWD
> - bool "SDHCI OF support for the Nintendo Wii SDHCI controllers"
> + tristate "SDHCI OF support for the Nintendo Wii SDHCI controllers"
> depends on MMC_SDHCI_OF
> depends on PPC_OF
> select MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER
> @@ -124,7 +124,7 @@ config MMC_SDHCI_PLTFM
> If unsure, say N.
>
> config MMC_SDHCI_CNS3XXX
> - bool "SDHCI support on the Cavium Networks CNS3xxx SoC"
> + tristate "SDHCI support on the Cavium Networks CNS3xxx SoC"
> depends on ARCH_CNS3XXX
> depends on MMC_SDHCI_PLTFM
> help
> @@ -133,7 +133,7 @@ config MMC_SDHCI_CNS3XXX
> If unsure, say N.
>
> config MMC_SDHCI_ESDHC_IMX
> - bool "SDHCI platform support for the Freescale eSDHC i.MX controller"
> + tristate "SDHCI platform support for the Freescale eSDHC i.MX controller"
> depends on MMC_SDHCI_PLTFM && (ARCH_MX25 || ARCH_MX35 || ARCH_MX5)
> select MMC_SDHCI_IO_ACCESSORS
> help
> @@ -143,7 +143,7 @@ config MMC_SDHCI_ESDHC_IMX
> If unsure, say N.
>
> config MMC_SDHCI_DOVE
> - bool "SDHCI support on Marvell's Dove SoC"
> + tristate "SDHCI support on Marvell's Dove SoC"
> depends on ARCH_DOVE
> depends on MMC_SDHCI_PLTFM
> select MMC_SDHCI_IO_ACCESSORS
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'
2011-03-28 14:38 ` Shawn Guo
@ 2011-03-29 1:57 ` Chris Ball
2011-03-30 16:46 ` Lars-Peter Clausen
0 siblings, 1 reply; 7+ messages in thread
From: Chris Ball @ 2011-03-29 1:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Shawn,
On Mon, Mar 28 2011, Shawn Guo wrote:
> Hi Chris,
>
> Any comment on this one?
Yep, I'll push it to mmc-next once -rc1 is released.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'
2011-03-29 1:57 ` Chris Ball
@ 2011-03-30 16:46 ` Lars-Peter Clausen
2011-03-30 16:57 ` Chris Ball
0 siblings, 1 reply; 7+ messages in thread
From: Lars-Peter Clausen @ 2011-03-30 16:46 UTC (permalink / raw)
To: linux-arm-kernel
On 03/29/2011 03:57 AM, Chris Ball wrote:
> Hi Shawn,
>
> On Mon, Mar 28 2011, Shawn Guo wrote:
>> Hi Chris,
>>
>> Any comment on this one?
>
> Yep, I'll push it to mmc-next once -rc1 is released.
>
> Thanks,
>
> - Chris.
That patch doesn't make much sense. The config options are used to decide
whether support for that platform should be build into the sdhci-platform or
sdhci-of module. So setting them 'm' doesn't make any sense, since you can't
build part of an module as a module. The effect for 'm' will probably be the
same as for 'n'.
- Lars
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'
2011-03-30 16:46 ` Lars-Peter Clausen
@ 2011-03-30 16:57 ` Chris Ball
2011-03-31 1:37 ` Shawn Guo
0 siblings, 1 reply; 7+ messages in thread
From: Chris Ball @ 2011-03-30 16:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Lars,
On Wed, Mar 30 2011, Lars-Peter Clausen wrote:
> That patch doesn't make much sense. The config options are used to decide
> whether support for that platform should be build into the sdhci-platform or
> sdhci-of module. So setting them 'm' doesn't make any sense, since you can't
> build part of an module as a module. The effect for 'm' will probably be the
> same as for 'n'.
Thanks, makes sense -- I'll drop the patch.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'
2011-03-30 16:57 ` Chris Ball
@ 2011-03-31 1:37 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2011-03-31 1:37 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 30, 2011 at 12:57:06PM -0400, Chris Ball wrote:
> Hi Lars,
>
> On Wed, Mar 30 2011, Lars-Peter Clausen wrote:
> > That patch doesn't make much sense. The config options are used to decide
> > whether support for that platform should be build into the sdhci-platform or
> > sdhci-of module. So setting them 'm' doesn't make any sense, since you can't
> > build part of an module as a module. The effect for 'm' will probably be the
> > same as for 'n'.
>
> Thanks, makes sense -- I'll drop the patch.
>
Then, you are going to need the patch below I just posted in the same
thread.
[PATCH] mmc: sdhci: change CONFIG of MMC_SDHCI_TEGRA from 'tristate' to 'bool'
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: sdhci: change CONFIG of MMC_SDHCI_TEGRA from 'tristate' to 'bool'
2011-03-14 14:54 [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate' Shawn Guo
2011-03-28 14:38 ` Shawn Guo
@ 2011-03-31 1:31 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2011-03-31 1:31 UTC (permalink / raw)
To: linux-arm-kernel
From: Shawn Guo <shawn.guo@linaro.org>
This config option is used to decide whether tegra sdhci support
should be build into the sdhci-platform module. So setting it 'm'
is nonsense, since we can't build part of an module as a module.
The effect for 'm' will probably be the same as for 'n'.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
The commit message comes from the comment given by Lars-Peter Clausen
on another Naked patch :)
drivers/mmc/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 94df405..b981715 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -154,7 +154,7 @@ config MMC_SDHCI_DOVE
If unsure, say N.
config MMC_SDHCI_TEGRA
- tristate "SDHCI platform support for the Tegra SD/MMC Controller"
+ bool "SDHCI platform support for the Tegra SD/MMC Controller"
depends on MMC_SDHCI_PLTFM && ARCH_TEGRA
select MMC_SDHCI_IO_ACCESSORS
help
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-03-31 1:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-14 14:54 [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate' Shawn Guo
2011-03-28 14:38 ` Shawn Guo
2011-03-29 1:57 ` Chris Ball
2011-03-30 16:46 ` Lars-Peter Clausen
2011-03-30 16:57 ` Chris Ball
2011-03-31 1:37 ` Shawn Guo
2011-03-31 1:31 ` [PATCH] mmc: sdhci: change CONFIG of MMC_SDHCI_TEGRA from 'tristate' to 'bool' Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).