From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pwm: berlin: fix build warning
Date: Tue, 06 Oct 2015 21:56:20 +0200 [thread overview]
Message-ID: <13015728.LECQI3jOWk@wuerfel> (raw)
In-Reply-To: <20151005143015.GB27759@ulmo>
The newly added berlin pwm driver causes a build warning:
drivers/pwm/pwm-berlin.c: In function 'berlin_pwm_config':
drivers/pwm/pwm-berlin.c:61:32: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
struct berlin_pwm_chip *pwm = to_berlin_pwm_chip(chip);
This changes the prototype of the to_berlin_pwm_chip() the way it
was meant to be.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
On Monday 05 October 2015 16:30:15 Thierry Reding wrote:
> On Fri, Oct 02, 2015 at 04:59:47PM +0200, Antoine Tenart wrote:
> > Add a PWM controller driver for the Marvell Berlin SoCs. This PWM
> > controller has 4 channels.
> >
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> > Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> > ---
> > drivers/pwm/Kconfig | 9 ++
> > drivers/pwm/Makefile | 1 +
> > drivers/pwm/pwm-berlin.c | 221 +++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 231 insertions(+)
> > create mode 100644 drivers/pwm/pwm-berlin.c
>
> Applied, with minor tweaks, thanks.
Apparently the tweak has failed
diff --git a/drivers/pwm/pwm-berlin.c b/drivers/pwm/pwm-berlin.c
index a390de6a760f..97933d3b2cc4 100644
--- a/drivers/pwm/pwm-berlin.c
+++ b/drivers/pwm/pwm-berlin.c
@@ -33,7 +33,7 @@ struct berlin_pwm_chip {
void __iomem *base;
};
-static inline to_berlin_pwm_chip(struct pwm_chip *chip)
+static inline struct berlin_pwm_chip *to_berlin_pwm_chip(struct pwm_chip *chip)
{
return container_of((chip), struct berlin_pwm_chip, chip);
}
next prev parent reply other threads:[~2015-10-06 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 14:59 [PATCH v7 0/5] ARM: berlin: PWM support Antoine Tenart
2015-10-02 14:59 ` [PATCH v7 1/5] Documentation: bindings: document the Berlin PWM driver Antoine Tenart
2015-10-05 14:29 ` Thierry Reding
2015-10-02 14:59 ` [PATCH v7 2/5] pwm: add the Berlin pwm controller driver Antoine Tenart
2015-10-05 14:30 ` Thierry Reding
2015-10-06 19:56 ` Arnd Bergmann [this message]
2015-10-02 14:59 ` [PATCH v7 3/5] ARM: berlin: add a PWM node on the BG2Q Antoine Tenart
2015-10-05 18:19 ` Sebastian Hesselbarth
2015-10-02 14:59 ` [PATCH v7 4/5] ARM: berlin: add a PWM node on the BG2 Antoine Tenart
2015-10-02 14:59 ` [PATCH v7 5/5] ARM: berlin: add a PWM node on the BG2CD Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13015728.LECQI3jOWk@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox