From: omar.ramirez@ti.com (Omar Ramirez Luna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: BUG() dies silently
Date: Thu, 31 Mar 2011 14:15:23 -0600 [thread overview]
Message-ID: <1301602523-9906-1-git-send-email-omar.ramirez@ti.com> (raw)
There are some cases where the code generated for BUG() results
into an infinite while loop without causing a null dereference,
this ends on a kernel being stuck on a loop and the user without
a clue of what happened.
E.g.: lib/scatterlist.c : __sg_alloc_table
BUG_ON(nents > max_ents);
438: 9a000000 bls 440 <__sg_alloc_table+0x20>
43c: eafffffe b 43c <__sg_alloc_table+0x1c>
Adding volatile makes the compiler to avoid optimizations on this
code, which makes the panic to occur:
BUG_ON(nents > max_ents);
438: 9a000002 bls 448 <__sg_alloc_table+0x28>
43c: e3a03000 mov r3, #0
440: e5833000 str r3, [r3]
444: eafffffc b 43c <__sg_alloc_table+0x1c>
Seen with gnu/linux cs arm-2010q1-202 and arm2010.09-50.
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
If needed I can change:
./arch/arm/mach-clps711x/include/mach/io.h:
#define __raw_readsb(p,d,l) do { *(int *)0 = 0; } while (0)
./arch/arm/mach-clps711x/include/mach/io.h:
#define __raw_readsl(p,d,l) do { *(int *)0 = 0; } while (0)
./arch/arm/mach-clps711x/include/mach/io.h:
#define __raw_writesb(p,d,l) do { *(int *)0 = 0; } while (0)
./arch/arm/mach-clps711x/include/mach/io.h:
#define __raw_writesl(p,d,l) do { *(int *)0 = 0; } while (0)
./arch/arm/kernel/traps.c: *(int *)0 = 0;
arch/arm/include/asm/bug.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h
index 4d88425..a58d863 100644
--- a/arch/arm/include/asm/bug.h
+++ b/arch/arm/include/asm/bug.h
@@ -12,7 +12,7 @@ extern void __bug(const char *file, int line) __attribute__((noreturn));
#else
/* this just causes an oops */
-#define BUG() do { *(int *)0 = 0; } while (1)
+#define BUG() do { *(volatile int *)0 = 0; } while(1)
#endif
--
1.7.1
next reply other threads:[~2011-03-31 20:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 20:15 Omar Ramirez Luna [this message]
2011-04-01 1:47 ` [PATCH] ARM: BUG() dies silently Simon Glass
2011-04-01 8:44 ` Stephen Boyd
2011-04-01 22:29 ` Simon Glass
2011-04-03 7:15 ` Stephen Boyd
2011-04-05 1:55 ` Simon Glass
2011-04-05 17:36 ` Stephen Boyd
2011-04-05 2:29 ` Ramirez Luna, Omar
2011-04-05 5:46 ` Simon Glass
2011-04-05 16:02 ` Ramirez Luna, Omar
2011-04-05 16:43 ` Simon Glass
2011-09-17 6:07 ` Rabin Vincent
2011-09-19 14:26 ` Ramirez Luna, Omar
2011-09-19 14:43 ` Russell King - ARM Linux
2011-09-19 16:59 ` Russell King - ARM Linux
2011-09-19 18:02 ` Simon Glass
2011-09-19 18:25 ` Russell King - ARM Linux
2011-09-19 18:32 ` Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301602523-9906-1-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).