From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] ARM: gic: use handle_fasteoi_irq for SPIs
Date: Sun, 03 Apr 2011 13:17:01 +0100 [thread overview]
Message-ID: <1301833021.5022.4.camel@jazzbox> (raw)
In-Reply-To: <BANLkTimJwCkabdEhQ89NgEaWyYaX6kSgUQ@mail.gmail.com>
Hello,
On Sun, 2011-04-03 at 04:27 +0100, Colin Cross wrote:
> In further testing I found one bug. d7ed36a added gic_arch_extn,
> which needs to be used in gic_eoi. arch/arm/mach-tegra/irq.c will
> need to be fixed to replace tegra_ack with tegra_eoi, and any other
> platform that uses gic_arch_extn also needs to be checked (omap4?).
Ok, I'll do some grepping around for those guys. I didn't realise they
were already being used.
> This patch fixes gic.c:
>
> diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
> index 6ecd5c7..8e46dac 100644
> --- a/arch/arm/common/gic.c
> +++ b/arch/arm/common/gic.c
> @@ -118,7 +118,11 @@ static void gic_unmask_irq(struct irq_data *d)
>
> static void gic_eoi_irq(struct irq_data *d)
> {
> + spin_lock(&irq_controller_lock);
> + if (gic_arch_extn.irq_eoi)
> + gic_arch_extn.irq_eoi(d);
> writel(gic_irq(d), gic_cpu_base(d) + GIC_CPU_EOI);
> + spin_unlock(&irq_controller_lock);
> }
>
> static int gic_set_type(struct irq_data *d, unsigned int type)
Hmm, I don't like that spinlock. Are the gic_arch_extn.* pointers ever
modified after being set initially? If not, can we make the locking
conditional on that pointer being non-NULL?
Will
next prev parent reply other threads:[~2011-04-03 12:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 14:50 [PATCH 0/6] Use chained handler entry/exit functions in platform code Will Deacon
2011-04-01 14:50 ` [PATCH 1/6] ARM: omap: update GPIO chained IRQ handler to use entry/exit functions Will Deacon
2011-04-01 14:50 ` [PATCH 2/6] ARM: tegra: " Will Deacon
2011-04-01 20:29 ` Colin Cross
2011-04-03 12:13 ` Will Deacon
2011-04-01 14:50 ` [PATCH 3/6] ARM: s5pv310: update IRQ combiner to use chained " Will Deacon
2011-04-01 14:50 ` [PATCH 4/6] ARM: msm: update GPIO chained IRQ handler to use " Will Deacon
2011-04-01 14:50 ` [PATCH 5/6] ARM: nmk: update GPIO chained IRQ handler to " Will Deacon
2011-04-01 14:50 ` [PATCH 6/6] ARM: gic: use handle_fasteoi_irq for SPIs Will Deacon
2011-04-01 20:31 ` Colin Cross
2011-04-03 3:27 ` Colin Cross
2011-04-03 6:06 ` Santosh Shilimkar
2011-04-03 12:18 ` Will Deacon
2011-04-03 12:20 ` Santosh Shilimkar
2011-04-03 12:17 ` Will Deacon [this message]
2011-04-03 22:38 ` Colin Cross
2011-04-05 12:48 ` Will Deacon
-- strict thread matches above, loose matches on Subject: below --
2011-04-12 18:35 [PATCH v2 0/6] Use chained handler entry/exit functions in platform code Will Deacon
2011-04-12 18:35 ` [PATCH 6/6] ARM: gic: use handle_fasteoi_irq for SPIs Will Deacon
2011-04-16 1:52 ` Abhijeet Dharmapurikar
2011-04-19 11:20 ` Santosh Shilimkar
2011-04-19 15:16 ` Will Deacon
2011-04-20 4:20 ` Santosh Shilimkar
2011-04-30 2:38 ` Colin Cross
2011-04-30 9:54 ` Thomas Gleixner
2011-04-30 16:42 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301833021.5022.4.camel@jazzbox \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).