From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] video: mxsfb: correct typo 'FAILING' to 'FALLING'
Date: Tue, 5 Apr 2011 14:47:55 +0800 [thread overview]
Message-ID: <1301986075-3168-1-git-send-email-shawn.guo@freescale.com> (raw)
In-Reply-To: <20110404150430.GB13963@pengutronix.de>
Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
---
The patch should probably be split into two to separate machine code
changes from driver ones, but that will result in build failure,
which could be a problem for bisect, so I keep them as one patch.
arch/arm/mach-mxs/include/mach/mxsfb.h | 2 +-
arch/arm/mach-mxs/mach-mx23evk.c | 2 +-
arch/arm/mach-mxs/mach-mx28evk.c | 2 +-
drivers/video/mxsfb.c | 6 +++---
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-mxs/include/mach/mxsfb.h b/arch/arm/mach-mxs/include/mach/mxsfb.h
index e4d7979..491787e 100644
--- a/arch/arm/mach-mxs/include/mach/mxsfb.h
+++ b/arch/arm/mach-mxs/include/mach/mxsfb.h
@@ -25,7 +25,7 @@
#define STMLCDIF_24BIT 3 /** pixel data bus to the display is of 24 bit width */
#define FB_SYNC_DATA_ENABLE_HIGH_ACT (1 << 6)
-#define FB_SYNC_DOTCLK_FAILING_ACT (1 << 7) /* failing/negtive edge sampling */
+#define FB_SYNC_DOTCLK_FALLING_ACT (1 << 7) /* falling/negtive edge sampling */
struct mxsfb_platform_data {
struct fb_videomode *mode_list;
diff --git a/arch/arm/mach-mxs/mach-mx23evk.c b/arch/arm/mach-mxs/mach-mx23evk.c
index 214e5b6..bcf24c1 100644
--- a/arch/arm/mach-mxs/mach-mx23evk.c
+++ b/arch/arm/mach-mxs/mach-mx23evk.c
@@ -122,7 +122,7 @@ static struct fb_videomode mx23evk_video_modes[] = {
.hsync_len = 1,
.vsync_len = 1,
.sync = FB_SYNC_DATA_ENABLE_HIGH_ACT |
- FB_SYNC_DOTCLK_FAILING_ACT,
+ FB_SYNC_DOTCLK_FALLING_ACT,
},
};
diff --git a/arch/arm/mach-mxs/mach-mx28evk.c b/arch/arm/mach-mxs/mach-mx28evk.c
index bb329b9..9753e85 100644
--- a/arch/arm/mach-mxs/mach-mx28evk.c
+++ b/arch/arm/mach-mxs/mach-mx28evk.c
@@ -311,7 +311,7 @@ static struct fb_videomode mx28evk_video_modes[] = {
.hsync_len = 10,
.vsync_len = 10,
.sync = FB_SYNC_DATA_ENABLE_HIGH_ACT |
- FB_SYNC_DOTCLK_FAILING_ACT,
+ FB_SYNC_DOTCLK_FALLING_ACT,
},
};
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 7d02848..aa27231 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -103,7 +103,7 @@
#define VDCTRL0_ENABLE_PRESENT (1 << 28)
#define VDCTRL0_VSYNC_ACT_HIGH (1 << 27)
#define VDCTRL0_HSYNC_ACT_HIGH (1 << 26)
-#define VDCTRL0_DOTCLK_ACT_FAILING (1 << 25)
+#define VDCTRL0_DOTCLK_ACT_FALLING (1 << 25)
#define VDCTRL0_ENABLE_ACT_HIGH (1 << 24)
#define VDCTRL0_VSYNC_PERIOD_UNIT (1 << 21)
#define VDCTRL0_VSYNC_PULSE_WIDTH_UNIT (1 << 20)
@@ -453,8 +453,8 @@ static int mxsfb_set_par(struct fb_info *fb_info)
vdctrl0 |= VDCTRL0_VSYNC_ACT_HIGH;
if (fb_info->var.sync & FB_SYNC_DATA_ENABLE_HIGH_ACT)
vdctrl0 |= VDCTRL0_ENABLE_ACT_HIGH;
- if (fb_info->var.sync & FB_SYNC_DOTCLK_FAILING_ACT)
- vdctrl0 |= VDCTRL0_DOTCLK_ACT_FAILING;
+ if (fb_info->var.sync & FB_SYNC_DOTCLK_FALLING_ACT)
+ vdctrl0 |= VDCTRL0_DOTCLK_ACT_FALLING;
writel(vdctrl0, host->base + LCDC_VDCTRL0);
--
1.7.1
next prev parent reply other threads:[~2011-04-05 6:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 16:18 A few mxsfb patches Shawn Guo
2011-03-05 16:18 ` [PATCH 1/3] video: mxsfb: smarten the code a little bit Shawn Guo
2011-03-05 16:41 ` Arnd Bergmann
2011-03-06 4:09 ` Shawn Guo
2011-03-06 6:30 ` Shawn Guo
2011-03-06 6:18 ` [PATCH 1/3 RESEND] " Shawn Guo
2011-03-05 16:18 ` [PATCH 2/3] video: mxsfb: fix the incorrect error checking for alloc_pages_exact Shawn Guo
2011-03-05 16:18 ` [PATCH 3/3] video: mxsfb: add DOTCLK polarity configuration support Shawn Guo
2011-04-04 15:04 ` Uwe Kleine-König
2011-04-04 15:42 ` Shawn Guo
2011-04-05 5:53 ` Lothar Waßmann
2011-04-05 6:24 ` Shawn Guo
2011-04-05 7:32 ` Uwe Kleine-König
2011-04-05 6:47 ` Shawn Guo [this message]
2011-04-05 7:36 ` [PATCH] video: mxsfb: correct typo 'FAILING' to 'FALLING' Uwe Kleine-König
2011-03-07 7:26 ` A few mxsfb patches Sascha Hauer
2011-03-07 7:45 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301986075-3168-1-git-send-email-shawn.guo@freescale.com \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).