From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] OMAP2+: PM: Initialise sleep_switch to a non-valid value
Date: Tue, 5 Apr 2011 18:14:56 +0530 [thread overview]
Message-ID: <1302007497-10525-4-git-send-email-rnayak@ti.com> (raw)
In-Reply-To: <1302007497-10525-3-git-send-email-rnayak@ti.com>
sleep_switch which is initialised to 0 in omap_set_pwrdm_state
happens to be a valid sleep_switch type (FORCEWAKEUP_SWITCH)
which are defined as
#define FORCEWAKEUP_SWITCH 0
#define LOWPOWERSTATE_SWITCH 1
This causes the function to wrongly program some clock domains
even when the Powerdomain is in ON state.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
---
arch/arm/mach-omap2/pm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
index 30af335..04b6da7 100644
--- a/arch/arm/mach-omap2/pm.c
+++ b/arch/arm/mach-omap2/pm.c
@@ -105,7 +105,7 @@ static void omap2_init_processor_devices(void)
int omap_set_pwrdm_state(struct powerdomain *pwrdm, u32 state)
{
u32 cur_state;
- int sleep_switch = 0;
+ int sleep_switch = -1;
int ret = 0;
if (pwrdm == NULL || IS_ERR(pwrdm))
--
1.7.0.4
next prev parent reply other threads:[~2011-04-05 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 12:44 [PATCH 0/4] OMAP2+: Fix clockdomain state programming Rajendra Nayak
2011-04-05 12:44 ` [PATCH 1/4] OMAP2+: clockdomain: Add an api to read idle mode Rajendra Nayak
2011-04-05 12:44 ` [PATCH 2/4] OMAP2+: clockdomain: Add SoC support for clkdm_is_idle Rajendra Nayak
2011-04-05 12:44 ` Rajendra Nayak [this message]
2011-04-05 12:44 ` [PATCH 4/4] OMAP2+: PM: idle clkdms only if already in idle Rajendra Nayak
2011-04-05 13:39 ` [PATCH 1/4] OMAP2+: clockdomain: Add an api to read idle mode Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302007497-10525-4-git-send-email-rnayak@ti.com \
--to=rnayak@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).