* [PATCH] arm: Fix .size directive for xscale_dma_a0_map_area
@ 2011-03-12 3:27 Ben Hutchings
2011-04-07 23:47 ` Ben Hutchings
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2011-03-12 3:27 UTC (permalink / raw)
To: linux-arm-kernel
gas used to accept (and ignore?) .size directives which referred to
undefined symbols, as this does. In binutils 2.21 these are treated
as fatal errors.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
I missed this one previously because my 5-minute script didn't recognise
the ENDPROC macro as generating a .size directive.
Ben.
arch/arm/mm/proc-xscale.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
index 5a37c5e..ab00b59 100644
--- a/arch/arm/mm/proc-xscale.S
+++ b/arch/arm/mm/proc-xscale.S
@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
teq r2, #DMA_TO_DEVICE
beq xscale_dma_clean_range
b xscale_dma_flush_range
-ENDPROC(xscsale_dma_a0_map_area)
+ENDPROC(xscale_dma_a0_map_area)
/*
* dma_unmap_area(start, size, dir)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] arm: Fix .size directive for xscale_dma_a0_map_area
2011-03-12 3:27 [PATCH] arm: Fix .size directive for xscale_dma_a0_map_area Ben Hutchings
@ 2011-04-07 23:47 ` Ben Hutchings
0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2011-04-07 23:47 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 2011-03-12 at 03:27 +0000, Ben Hutchings wrote:
> gas used to accept (and ignore?) .size directives which referred to
> undefined symbols, as this does. In binutils 2.21 these are treated
> as fatal errors.
Please acknowledge and send this upstream.
You also haven't responded to my patch fixing .size directives for
__arm{7,9}tdmi_proc_info.
Ben.
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> I missed this one previously because my 5-minute script didn't recognise
> the ENDPROC macro as generating a .size directive.
>
> Ben.
>
> arch/arm/mm/proc-xscale.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
> index 5a37c5e..ab00b59 100644
> --- a/arch/arm/mm/proc-xscale.S
> +++ b/arch/arm/mm/proc-xscale.S
> @@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
> teq r2, #DMA_TO_DEVICE
> beq xscale_dma_clean_range
> b xscale_dma_flush_range
> -ENDPROC(xscsale_dma_a0_map_area)
> +ENDPROC(xscale_dma_a0_map_area)
>
> /*
> * dma_unmap_area(start, size, dir)
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110408/e0707e03/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-07 23:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-12 3:27 [PATCH] arm: Fix .size directive for xscale_dma_a0_map_area Ben Hutchings
2011-04-07 23:47 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).