* [PATCH linux-omap-pm/pm-wip/cpufreq] OMAP2PLUS: cpufreq: Fix typo when attempting to set mpu_clk for OMAP4
@ 2011-04-14 13:21 Jarkko Nikula
2011-04-14 15:02 ` Santosh Shilimkar
2011-04-19 22:50 ` Kevin Hilman
0 siblings, 2 replies; 3+ messages in thread
From: Jarkko Nikula @ 2011-04-14 13:21 UTC (permalink / raw)
To: linux-arm-kernel
Fix this typo as there is no dpll_mpu_ck for OMAP3 and code flow is clearly
trying to set mpu_clk for OMAP4 for which this dpll_mpu_ck is available.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
arch/arm/mach-omap2/omap2plus-cpufreq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
index 8d472f6..d53ce23 100644
--- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
+++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
@@ -161,7 +161,7 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
mpu_clk = clk_get(NULL, "virt_prcm_set");
else if (cpu_is_omap34xx())
mpu_clk = clk_get(NULL, "dpll1_ck");
- else if (cpu_is_omap34xx())
+ else if (cpu_is_omap44xx())
mpu_clk = clk_get(NULL, "dpll_mpu_ck");
if (IS_ERR(mpu_clk))
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH linux-omap-pm/pm-wip/cpufreq] OMAP2PLUS: cpufreq: Fix typo when attempting to set mpu_clk for OMAP4
2011-04-14 13:21 [PATCH linux-omap-pm/pm-wip/cpufreq] OMAP2PLUS: cpufreq: Fix typo when attempting to set mpu_clk for OMAP4 Jarkko Nikula
@ 2011-04-14 15:02 ` Santosh Shilimkar
2011-04-19 22:50 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2011-04-14 15:02 UTC (permalink / raw)
To: linux-arm-kernel
On 4/14/2011 6:51 PM, Jarkko Nikula wrote:
> Fix this typo as there is no dpll_mpu_ck for OMAP3 and code flow is clearly
> trying to set mpu_clk for OMAP4 for which this dpll_mpu_ck is available.
>
> Signed-off-by: Jarkko Nikula<jhnikula@gmail.com>
> ---
> arch/arm/mach-omap2/omap2plus-cpufreq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> index 8d472f6..d53ce23 100644
> --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
> +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> @@ -161,7 +161,7 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
> mpu_clk = clk_get(NULL, "virt_prcm_set");
> else if (cpu_is_omap34xx())
> mpu_clk = clk_get(NULL, "dpll1_ck");
> - else if (cpu_is_omap34xx())
> + else if (cpu_is_omap44xx())
My Bad :(
Thanks Jarkko for finding this.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH linux-omap-pm/pm-wip/cpufreq] OMAP2PLUS: cpufreq: Fix typo when attempting to set mpu_clk for OMAP4
2011-04-14 13:21 [PATCH linux-omap-pm/pm-wip/cpufreq] OMAP2PLUS: cpufreq: Fix typo when attempting to set mpu_clk for OMAP4 Jarkko Nikula
2011-04-14 15:02 ` Santosh Shilimkar
@ 2011-04-19 22:50 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2011-04-19 22:50 UTC (permalink / raw)
To: linux-arm-kernel
Jarkko Nikula <jhnikula@gmail.com> writes:
> Fix this typo as there is no dpll_mpu_ck for OMAP3 and code flow is clearly
> trying to set mpu_clk for OMAP4 for which this dpll_mpu_ck is available.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Thanks, applied to pm-wip/cpufreq branch.
Kevin
> ---
> arch/arm/mach-omap2/omap2plus-cpufreq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> index 8d472f6..d53ce23 100644
> --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
> +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> @@ -161,7 +161,7 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
> mpu_clk = clk_get(NULL, "virt_prcm_set");
> else if (cpu_is_omap34xx())
> mpu_clk = clk_get(NULL, "dpll1_ck");
> - else if (cpu_is_omap34xx())
> + else if (cpu_is_omap44xx())
> mpu_clk = clk_get(NULL, "dpll_mpu_ck");
>
> if (IS_ERR(mpu_clk))
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-19 22:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-14 13:21 [PATCH linux-omap-pm/pm-wip/cpufreq] OMAP2PLUS: cpufreq: Fix typo when attempting to set mpu_clk for OMAP4 Jarkko Nikula
2011-04-14 15:02 ` Santosh Shilimkar
2011-04-19 22:50 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).