From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: compressed/misc.c: simplify decompress_kernel()
Date: Wed, 20 Apr 2011 00:15:03 -0400 [thread overview]
Message-ID: <1303272904-31392-3-git-send-email-nicolas.pitre@linaro.org> (raw)
In-Reply-To: <1303272904-31392-1-git-send-email-nicolas.pitre@linaro.org>
The return value for decompress_kernel() is no longer used. Furthermore,
this was obtained and stored in a variable called output_ptr which is
a complete misnomer for what is actually the size of the decompressed
kernel image. Let's get rid of it.
Signed-off-by: Nicolas Pitre <nicolas.pitre@linaro.org>
---
BTW, I've yet to understand why, but this patch makes CONFIG_KERNEL_LZMA
work for me.
arch/arm/boot/compressed/misc.c | 13 ++-----------
1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/compressed/misc.c b/arch/arm/boot/compressed/misc.c
index 2df3826..a565853 100644
--- a/arch/arm/boot/compressed/misc.c
+++ b/arch/arm/boot/compressed/misc.c
@@ -26,8 +26,6 @@ unsigned int __machine_arch_type;
#include <linux/linkage.h>
#include <asm/string.h>
-#include <asm/unaligned.h>
-
static void putstr(const char *ptr);
extern void error(char *x);
@@ -139,13 +137,12 @@ void *memcpy(void *__dest, __const void *__src, size_t __n)
}
/*
- * gzip delarations
+ * gzip declarations
*/
extern char input_data[];
extern char input_data_end[];
unsigned char *output_data;
-unsigned long output_ptr;
unsigned long free_mem_ptr;
unsigned long free_mem_end_ptr;
@@ -173,13 +170,11 @@ asmlinkage void __div0(void)
extern void do_decompress(u8 *input, int len, u8 *output, void (*error)(char *x));
-unsigned long
+void
decompress_kernel(unsigned long output_start, unsigned long free_mem_ptr_p,
unsigned long free_mem_ptr_end_p,
int arch_id)
{
- unsigned char *tmp;
-
output_data = (unsigned char *)output_start;
free_mem_ptr = free_mem_ptr_p;
free_mem_end_ptr = free_mem_ptr_end_p;
@@ -187,12 +182,8 @@ decompress_kernel(unsigned long output_start, unsigned long free_mem_ptr_p,
arch_decomp_setup();
- tmp = (unsigned char *) (((unsigned long)input_data_end) - 4);
- output_ptr = get_unaligned_le32(tmp);
-
putstr("Uncompressing Linux...");
do_decompress(input_data, input_data_end - input_data,
output_data, error);
putstr(" done, booting the kernel.\n");
- return output_ptr;
}
--
1.7.4
next prev parent reply other threads:[~2011-04-20 4:15 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 4:15 [PATCH 0/3] fix some issues with the kernel decompressor Nicolas Pitre
2011-04-20 4:15 ` [PATCH 1/3] ARM: zImage: no need to get the decompressed size from the filesystem Nicolas Pitre
2011-04-21 12:47 ` Tony Lindgren
2011-04-20 4:15 ` Nicolas Pitre [this message]
2011-04-21 12:49 ` [PATCH 2/3] ARM: compressed/misc.c: simplify decompress_kernel() Tony Lindgren
2011-04-27 8:53 ` Russell King - ARM Linux
2011-04-27 14:48 ` Nicolas Pitre
2011-04-28 8:12 ` Russell King - ARM Linux
2011-04-28 8:17 ` Tony Lindgren
2011-04-28 18:20 ` Nicolas Pitre
2011-04-29 7:17 ` Tony Lindgren
2011-04-20 4:15 ` [PATCH 3/3] ARM: zImage: fix issues with missing GOT entries for some global variables Nicolas Pitre
2011-04-20 8:42 ` Uwe Kleine-König
2011-04-20 9:19 ` Shawn Guo
2011-04-20 12:28 ` Nicolas Pitre
2011-04-20 12:36 ` Uwe Kleine-König
2011-04-20 12:47 ` Nicolas Pitre
2011-04-27 8:58 ` Russell King - ARM Linux
2011-04-27 15:00 ` Nicolas Pitre
2011-04-20 12:52 ` Shawn Guo
2011-04-20 13:03 ` Nicolas Pitre
2011-04-20 13:17 ` Nicolas Pitre
2011-04-21 12:50 ` Tony Lindgren
2011-04-27 8:55 ` Russell King - ARM Linux
2011-04-27 14:55 ` Nicolas Pitre
2011-04-20 7:21 ` [PATCH 0/3] fix some issues with the kernel decompressor Tony Lindgren
2011-04-20 13:00 ` Nicolas Pitre
2011-04-20 16:55 ` Tony Lindgren
2011-04-20 17:19 ` Nicolas Pitre
2011-04-21 5:59 ` Tony Lindgren
2011-04-21 10:49 ` [PATCH] ARM: Fix relocation if image end past uncompressed kernel end Tony Lindgren
2011-04-21 13:22 ` Nicolas Pitre
2011-04-21 21:26 ` Nicolas Pitre
2011-04-22 3:23 ` Nicolas Pitre
2011-04-22 5:19 ` Shawn Guo
2011-04-22 5:36 ` Shawn Guo
2011-04-22 6:28 ` Tony Lindgren
2011-04-22 14:12 ` Nicolas Pitre
2011-04-26 8:57 ` Tony Lindgren
2011-04-26 12:37 ` [PATCH] ARM: Fix bad SP address after relocating kernel Tony Lindgren
2011-04-26 21:31 ` Nicolas Pitre
2011-04-27 7:48 ` Tony Lindgren
2011-04-22 6:09 ` [PATCH] ARM: Fix relocation if image end past uncompressed kernel end Tony Lindgren
2011-04-27 12:47 ` Tony Lindgren
2011-04-27 12:56 ` Tony Lindgren
2011-04-27 22:16 ` Nicolas Pitre
2011-04-28 6:38 ` Tony Lindgren
2011-04-28 8:12 ` Tony Lindgren
2011-04-20 11:16 ` [PATCH 0/3] fix some issues with the kernel decompressor Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303272904-31392-3-git-send-email-nicolas.pitre@linaro.org \
--to=nicolas.pitre@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).