From: swarren@nvidia.com (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: tegra: Harmony: Register and configure WM8903 IRQ GPIO
Date: Thu, 21 Apr 2011 12:01:32 -0600 [thread overview]
Message-ID: <1303408892-7472-5-git-send-email-swarren@nvidia.com> (raw)
In-Reply-To: <1303408892-7472-1-git-send-email-swarren@nvidia.com>
Technically, we need to request and configure the GPIO used as the WM8903
interrupt. This prevents conflicting registrations, and assures that the
GPIO is correctly configured in all cases, e.g. if the bootloader left the
GPIO in some unexpected state.
In practice, the previous code works as-is, at least when using ChromeOS's
U-Boot as the boot-loader.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
Note: For Harmony, we don't have to do this inside harmony_pinmux_init
(see Seaboard's seaboard_pinmux_init in patch 3 in this series) because
pingroup SPIC pins are all input on Harmony.
arch/arm/mach-tegra/board-harmony.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-tegra/board-harmony.c b/arch/arm/mach-tegra/board-harmony.c
index 30e18bc..87cbc4b 100644
--- a/arch/arm/mach-tegra/board-harmony.c
+++ b/arch/arm/mach-tegra/board-harmony.c
@@ -131,6 +131,9 @@ static void __init harmony_i2c_init(void)
platform_device_register(&tegra_i2c_device3);
platform_device_register(&tegra_i2c_device4);
+ gpio_request(TEGRA_GPIO_CDC_IRQ, "wm8903");
+ gpio_direction_input(TEGRA_GPIO_CDC_IRQ);
+
i2c_register_board_info(0, &wm8903_board_info, 1);
}
--
1.7.1
next prev parent reply other threads:[~2011-04-21 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 18:01 [PATCH 0/4] Tegra patches for 2.6.40 Stephen Warren
2011-04-21 18:01 ` [PATCH 1/4] ARM: Tegra: Harmony: Fix conflicting GPIO numbering Stephen Warren
2011-04-21 18:01 ` [PATCH 2/4] ARM: Tegra: Seaboard: Re-order sdhci device registration Stephen Warren
2011-04-21 18:01 ` [PATCH 3/4] ARM: Tegra: Seaboard board updates for audio Stephen Warren
2011-04-21 18:01 ` Stephen Warren [this message]
2011-04-25 18:32 ` [PATCH 0/4] Tegra patches for 2.6.40 Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303408892-7472-5-git-send-email-swarren@nvidia.com \
--to=swarren@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).