From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] echi: remove structure packing from ehci_def
Date: Wed, 27 Apr 2011 20:04:01 +0530 [thread overview]
Message-ID: <1303914841-6379-1-git-send-email-rabin@rab.in> (raw)
As pointed out by Arnd Bergmann, in include/linux/usb/ehci_def.h, struct
ehci_caps is defined with __attribute__((packed)) for no good reason,
and this triggers undefined behaviour when using ARM's readl() on
pointers to elements of this structure:
http://lkml.kernel.org/r/201102021700.20683.arnd at arndb.de
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Rabin Vincent <rabin@rab.in>
---
include/linux/usb/ehci_def.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/usb/ehci_def.h b/include/linux/usb/ehci_def.h
index e49dfd4..7879943 100644
--- a/include/linux/usb/ehci_def.h
+++ b/include/linux/usb/ehci_def.h
@@ -52,7 +52,7 @@ struct ehci_caps {
#define HCC_PGM_FRAMELISTLEN(p) ((p)&(1 << 1)) /* true: periodic_size changes*/
#define HCC_64BIT_ADDR(p) ((p)&(1)) /* true: can use 64-bit addr */
u8 portroute[8]; /* nibbles for routing - offset 0xC */
-} __attribute__ ((packed));
+};
/* Section 2.3 Host Controller Operational Registers */
@@ -150,7 +150,7 @@ struct ehci_regs {
#define PORT_CSC (1<<1) /* connect status change */
#define PORT_CONNECT (1<<0) /* device connected */
#define PORT_RWC_BITS (PORT_CSC | PORT_PEC | PORT_OCC)
-} __attribute__ ((packed));
+};
#define USBMODE 0x68 /* USB Device mode */
#define USBMODE_SDIS (1<<3) /* Stream disable */
@@ -194,7 +194,7 @@ struct ehci_dbg_port {
u32 data47;
u32 address;
#define DBGP_EPADDR(dev, ep) (((dev)<<8)|(ep))
-} __attribute__ ((packed));
+};
#ifdef CONFIG_EARLY_PRINTK_DBGP
#include <linux/init.h>
--
1.7.4.1
next reply other threads:[~2011-04-27 14:34 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 14:34 Rabin Vincent [this message]
2011-04-27 15:15 ` [PATCH] echi: remove structure packing from ehci_def Sergei Shtylyov
2011-04-27 15:37 ` [PATCHv2] " Rabin Vincent
2011-06-16 16:17 ` [PATCH] USB: ehci: use packed, aligned(4) instead of removing the packed attribute Alexander Holler
2011-06-16 17:09 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-16 17:55 ` [PATCH] USB: ehci: use packed, aligned(4) " Arnd Bergmann
2011-06-16 19:25 ` [PATCH] USB: ehci: use packed,aligned(4) " Alexander Holler
2011-06-16 19:46 ` Alan Stern
2011-06-16 20:10 ` Alexander Holler
2011-06-16 20:20 ` [PATCH] USB: ehci: use packed, aligned(4) " Arnd Bergmann
2011-06-19 15:02 ` Nicolas Pitre
2011-06-19 19:00 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-19 20:02 ` [PATCH] USB: ehci: use packed, aligned(4) " Arnd Bergmann
2011-06-19 20:11 ` Arnd Bergmann
2011-06-19 21:39 ` Nicolas Pitre
2011-06-19 21:27 ` Nicolas Pitre
2011-06-20 15:03 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-20 16:16 ` [PATCH] USB: ehci: use packed, aligned(4) " Nicolas Pitre
2011-06-20 16:48 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-20 16:58 ` [PATCH] USB: ehci: use packed, aligned(4) " Arnd Bergmann
2011-06-20 19:02 ` Russell King - ARM Linux
2011-06-20 19:20 ` Nicolas Pitre
2011-06-20 19:29 ` Nicolas Pitre
2011-06-20 17:10 ` Nicolas Pitre
2011-06-20 17:35 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-20 18:48 ` Russell King - ARM Linux
2011-06-20 20:26 ` [PATCH] USB: ehci: use packed, aligned(4) " Arnd Bergmann
2011-06-20 20:50 ` Nicolas Pitre
2011-06-20 20:55 ` [PATCH] USB: ehci: use packed,aligned(4) " Russell King - ARM Linux
2011-06-20 21:23 ` [PATCH] USB: ehci: use packed, aligned(4) " Arnd Bergmann
2011-06-20 22:23 ` Nicolas Pitre
2011-06-21 11:25 ` Arnd Bergmann
2011-06-25 1:25 ` Nicolas Pitre
2011-06-25 8:09 ` Arnd Bergmann
2011-06-28 18:51 ` Nicolas Pitre
2011-06-29 10:56 ` Arnd Bergmann
2011-06-20 19:14 ` Nicolas Pitre
2011-06-20 19:32 ` Russell King - ARM Linux
2011-06-20 20:14 ` Arnd Bergmann
2011-06-20 20:42 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-20 22:36 ` [PATCH] USB: ehci: use packed, aligned(4) " Nicolas Pitre
2011-06-21 15:06 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-20 17:39 ` Alexander Holler
2011-06-20 18:39 ` Alan Stern
2011-06-20 18:46 ` Alexander Holler
2011-06-20 18:57 ` Alan Stern
2011-06-20 19:56 ` [PATCH] USB: ehci: use packed, aligned(4) " Nicolas Pitre
2011-06-20 21:04 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-20 22:31 ` [PATCH] USB: ehci: use packed, aligned(4) " Nicolas Pitre
2011-06-21 14:58 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-21 20:41 ` [PATCH] USB: ehci: use packed, aligned(4) " Nicolas Pitre
2011-06-22 6:23 ` [PATCH] USB: ehci: use packed,aligned(4) " Alexander Holler
2011-06-20 20:09 ` [PATCH] USB: ehci: use packed, aligned(4) " Arnd Bergmann
2011-06-20 21:05 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-20 20:07 ` [PATCH] USB: ehci: use packed, aligned(4) " Arnd Bergmann
2011-06-20 20:28 ` Nicolas Pitre
2011-06-20 20:39 ` Arnd Bergmann
2011-06-20 21:03 ` Nicolas Pitre
2011-06-23 9:47 ` Alexander Holler
2011-06-23 14:25 ` Alan Stern
2011-06-24 11:40 ` Alexander Holler
2011-06-20 16:26 ` Arnd Bergmann
2011-06-16 20:30 ` [PATCH] USB: ehci: use packed,aligned(4) " Alan Stern
2011-06-16 18:16 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303914841-6379-1-git-send-email-rabin@rab.in \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).