From: jean.pihet@newoldbits.com (jean.pihet at newoldbits.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] OMAP: cpuidle code clean-up
Date: Fri, 29 Apr 2011 11:26:21 +0200 [thread overview]
Message-ID: <1304069186-3086-1-git-send-email-j-pihet@ti.com> (raw)
From: Jean Pihet <j-pihet@ti.com>
Rework the cpuidle code:
- optimize the cpuidle C-states data registration and storage,
- change the interaction with the debugfs 'enable_off_mode' knob
and the use of the C-states 'valid' internal field,
- remove dead code,
- improve code readability.
Tested on Beagleboard B5 with cpuidle in RET and OFF modes.
Another 161 lines of OMAP code gone ;p
Notes:
1) the debugfs 'enable_off_mode' knob will be deprecated by the use
of the devices constraints framework to restrict the power domains
power modes.
2) the MPU and CORE power domains low power modes are controlled
by cpuidle, based on the allowed overall sleep+wake-up latencies
and the wake-up latency constraints on the MPU. This is incorrect.
The devices constraints framework shall be used instead to control
all power domains.
ToDo:
- integrate cpuidle with the devices constraints framework, when merged in,
- refine the latency figures and express them in term of available data
from other frameworks (OMAP PM, constaints framework, omap_devices,
new VC/VP voltage and DVFS code ...),
Jean Pihet (5):
OMAP3 cpuidle: remove useless SDP specific timings
OMAP3: clean-up mach specific cpuidle data structures
OMAP3: cpuidle: re-organize the C-states data
OMAP3: cpuidle: code rework for improved readability
OMAP3: cpuidle: change the power domains modes determination logic
arch/arm/mach-omap2/board-3430sdp.c | 19 --
arch/arm/mach-omap2/board-rx51.c | 15 +-
arch/arm/mach-omap2/cpuidle34xx.c | 424 ++++++++++++-----------------------
arch/arm/mach-omap2/pm.h | 17 +-
arch/arm/mach-omap2/pm34xx.c | 12 -
5 files changed, 163 insertions(+), 324 deletions(-)
next reply other threads:[~2011-04-29 9:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 9:26 jean.pihet at newoldbits.com [this message]
2011-04-29 9:26 ` [PATCH 1/5] OMAP3 cpuidle: remove useless SDP specific timings jean.pihet at newoldbits.com
2011-04-29 11:14 ` Santosh Shilimkar
2011-05-04 14:40 ` Kevin Hilman
2011-04-29 9:26 ` [PATCH 2/5] OMAP3: clean-up mach specific cpuidle data structures jean.pihet at newoldbits.com
2011-05-04 20:09 ` Kevin Hilman
2011-04-29 9:26 ` [PATCH 3/5] OMAP3: cpuidle: re-organize the C-states data jean.pihet at newoldbits.com
2011-04-29 11:24 ` Santosh Shilimkar
2011-05-04 14:59 ` Kevin Hilman
2011-04-29 9:26 ` [PATCH 4/5] OMAP3: cpuidle: code rework for improved readability jean.pihet at newoldbits.com
2011-05-04 15:32 ` Kevin Hilman
2011-04-29 9:26 ` [PATCH 5/5] OMAP3: cpuidle: change the power domains modes determination logic jean.pihet at newoldbits.com
2011-04-29 11:29 ` Santosh Shilimkar
2011-04-29 14:00 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304069186-3086-1-git-send-email-j-pihet@ti.com \
--to=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).