linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: philipp.zabel@gmail.com (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa/hx4700: Add ASIC3 LED support
Date: Tue, 03 May 2011 12:15:56 +0200	[thread overview]
Message-ID: <1304417758.13769.1.camel@flow> (raw)
In-Reply-To: <E1QGESE-0007gF-VJ@outmx08.plus.net>

Am Samstag, den 30.04.2011, 17:59 +0000 schrieb Paul Parsons:
> Add LED support for the HTC ASIC3. Underlying support is provided by the mfd/asic3 and leds/leds-asic3 drivers. An example configuration is provided by the pxa/hx4700 platform.
> 
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> ---
> diff -uprN clean-2.6.39-rc5/arch/arm/mach-pxa/hx4700.c linux-2.6.39-rc5/arch/arm/mach-pxa/hx4700.c
> --- clean-2.6.39-rc5/arch/arm/mach-pxa/hx4700.c	2011-04-28 11:18:09.310551240 +0100
> +++ linux-2.6.39-rc5/arch/arm/mach-pxa/hx4700.c	2011-04-30 15:52:19.956069045 +0100
> @@ -23,6 +23,7 @@
>  #include <linux/gpio_keys.h>
>  #include <linux/input.h>
>  #include <linux/lcd.h>
> +#include <linux/leds.h>

This is not needed anymore.

>  #include <linux/mfd/htc-egpio.h>
>  #include <linux/mfd/asic3.h>
>  #include <linux/mtd/physmap.h>
> @@ -280,6 +281,21 @@ static u16 asic3_gpio_config[] = {
>  	ASIC3_GPIOD15_nPIOW,
>  };
>  
> +static struct asic3_led asic3_leds[ASIC3_NUM_LEDS] = {
> +	[0] = {
> +		.name = "hx4700:amber",
> +		.default_trigger = "ds2760-battery.0-charging-blink-full-solid",
> +	},
> +	[1] = {
> +		.name = "hx4700:green",
> +		.default_trigger = "unused",
> +	},
> +	[2] = {
> +		.name = "hx4700:blue",
> +		.default_trigger = "hx4700-radio",
> +	},
> +};
> +
>  static struct resource asic3_resources[] = {
>  	/* GPIO part */
>  	[0] = {
> @@ -310,6 +326,7 @@ static struct asic3_platform_data asic3_
>  	.gpio_config_num = ARRAY_SIZE(asic3_gpio_config),
>  	.irq_base        = IRQ_BOARD_START,
>  	.gpio_base       = HX4700_ASIC3_GPIO_BASE,
> +	.leds            = asic3_leds,
>  };
>  
>  static struct platform_device asic3 = {

After removal of the superfluous include,
Acked-by: Philipp Zabel <philipp.zabel@gmail.com>

regards
Philipp

      reply	other threads:[~2011-05-03 10:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-30 17:59 [PATCH] pxa/hx4700: Add ASIC3 LED support Paul Parsons
2011-05-03 10:15 ` Philipp Zabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304417758.13769.1.camel@flow \
    --to=philipp.zabel@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).