From: jean.pihet@newoldbits.com (jean.pihet at newoldbits.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/4] OMAP: cpuidle code clean-up
Date: Mon, 9 May 2011 12:02:12 +0200 [thread overview]
Message-ID: <1304935336-6308-1-git-send-email-j-pihet@ti.com> (raw)
From: Jean Pihet <j-pihet@ti.com>
Rework of the OMAP2+ cpuidle code
v3: rework after comments on linux-omap ML:
- renamed the C-state driver data variables as 'cx',
- retain C1 as the only always valid state and safe state,
- rework of the C-states definition.
v2: rework after comments on linux-omap ML:
- remove useless macros,
- replace the C-state common data fill-in helper macro by an inline
function, for better readability,
- update commits description.
v1:
- optimize the cpuidle C-states data registration and storage,
- change the interaction with the debugfs 'enable_off_mode' knob
and the use of the C-states 'valid' internal field,
- remove dead code,
- improve code readability.
Tested on Beagleboard B5 with cpuidle in RET and OFF modes.
Another 151 lines of OMAP code gone ;p
Notes:
1) the debugfs 'enable_off_mode' knob will be deprecated by the use
of the devices constraints framework to restrict the power domains
power modes.
2) the MPU and CORE power domains low power modes are controlled
by cpuidle, based on the allowed overall sleep+wake-up latencies
and the wake-up latency constraints on the MPU. This is incorrect.
The devices constraints framework shall be used instead to control
all power domains.
ToDo:
- integrate cpuidle with the devices constraints framework, when merged in,
- refine the latency figures and express them in term of available data
from other frameworks (OMAP PM, constaints framework, omap_devices,
new VC/VP voltage and DVFS code ...),
Rebased on khilman's for_2.6.40/pm-cleanup branch
Jean Pihet (4):
OMAP3: clean-up mach specific cpuidle data structures
OMAP3: cpuidle: re-organize the C-states data
OMAP3: cpuidle: code rework for improved readability
OMAP3: cpuidle: change the power domains modes determination logic
arch/arm/mach-omap2/board-rx51.c | 18 +-
arch/arm/mach-omap2/cpuidle34xx.c | 436 +++++++++++++------------------------
arch/arm/mach-omap2/pm.h | 17 +-
arch/arm/mach-omap2/pm34xx.c | 12 -
4 files changed, 166 insertions(+), 317 deletions(-)
--
1.7.2.5
next reply other threads:[~2011-05-09 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 10:02 jean.pihet at newoldbits.com [this message]
2011-05-09 10:02 ` [PATCH 1/4] OMAP3: clean-up mach specific cpuidle data structures jean.pihet at newoldbits.com
2011-05-09 10:02 ` [PATCH 2/4] OMAP3: cpuidle: re-organize the C-states data jean.pihet at newoldbits.com
2011-05-09 10:02 ` [PATCH 3/4] OMAP3: cpuidle: code rework for improved readability jean.pihet at newoldbits.com
2011-05-09 10:02 ` [PATCH 4/4] OMAP3: cpuidle: change the power domains modes determination logic jean.pihet at newoldbits.com
2011-05-18 14:38 ` [PATCH v3 0/4] OMAP: cpuidle code clean-up Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304935336-6308-1-git-send-email-j-pihet@ti.com \
--to=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).