* [PATCH] regulator: mc13892: Fix voltage unit in test case.
@ 2011-05-15 22:53 Fabio Estevam
2011-05-15 23:01 ` Mark Brown
2011-05-16 12:17 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2011-05-15 22:53 UTC (permalink / raw)
To: linux-arm-kernel
Voltage values should be expressed in microvolts, not in milivolts.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Ranjani Vaidyanathan <ra5478@freescale.com>
---
drivers/regulator/mc13892-regulator.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index 6f15168..e90ba05 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -453,9 +453,9 @@ static int mc13892_sw_regulator_set_voltage(struct regulator_dev *rdev,
goto err;
hi = val & MC13892_SWITCHERS0_SWxHI;
- if (value > 1375)
+ if (value > 1375000)
hi = 1;
- if (value < 1100)
+ if (value < 1100000)
hi = 0;
if (hi) {
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] regulator: mc13892: Fix voltage unit in test case.
2011-05-15 22:53 [PATCH] regulator: mc13892: Fix voltage unit in test case Fabio Estevam
@ 2011-05-15 23:01 ` Mark Brown
2011-05-16 12:17 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-05-15 23:01 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, May 15, 2011 at 07:53:45PM -0300, Fabio Estevam wrote:
> Voltage values should be expressed in microvolts, not in milivolts.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Ranjani Vaidyanathan <ra5478@freescale.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] regulator: mc13892: Fix voltage unit in test case.
2011-05-15 22:53 [PATCH] regulator: mc13892: Fix voltage unit in test case Fabio Estevam
2011-05-15 23:01 ` Mark Brown
@ 2011-05-16 12:17 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-05-16 12:17 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, 2011-05-15 at 19:53 -0300, Fabio Estevam wrote:
> Voltage values should be expressed in microvolts, not in milivolts.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Ranjani Vaidyanathan <ra5478@freescale.com>
> ---
> drivers/regulator/mc13892-regulator.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
> index 6f15168..e90ba05 100644
> --- a/drivers/regulator/mc13892-regulator.c
> +++ b/drivers/regulator/mc13892-regulator.c
> @@ -453,9 +453,9 @@ static int mc13892_sw_regulator_set_voltage(struct regulator_dev *rdev,
> goto err;
>
> hi = val & MC13892_SWITCHERS0_SWxHI;
> - if (value > 1375)
> + if (value > 1375000)
> hi = 1;
> - if (value < 1100)
> + if (value < 1100000)
> hi = 0;
>
> if (hi) {
This doesn't apply against the regulator for-next branch. Could you redo
and add Mark's Ack.
Thanks.
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-16 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-15 22:53 [PATCH] regulator: mc13892: Fix voltage unit in test case Fabio Estevam
2011-05-15 23:01 ` Mark Brown
2011-05-16 12:17 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).