linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lrg@slimlogic.co.uk (Liam Girdwood)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] regulator: mc13892: Fix voltage unit in test case.
Date: Mon, 16 May 2011 21:19:00 +0100	[thread overview]
Message-ID: <1305577140.3156.13.camel@odin> (raw)
In-Reply-To: <1305554067-20643-1-git-send-email-fabio.estevam@freescale.com>

On Mon, 2011-05-16 at 10:54 -0300, Fabio Estevam wrote:
> Voltage values should be expressed in microvolts, not in milivolts.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Ranjani Vaidyanathan <ra5478@freescale.com>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> Changes since v1:
> 
> - Rebase it on top of Liam's regulator for-next tree.
>  
>  drivers/regulator/mc13892-regulator.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
> index 73347c8..6fffe67 100644
> --- a/drivers/regulator/mc13892-regulator.c
> +++ b/drivers/regulator/mc13892-regulator.c
> @@ -453,9 +453,9 @@ static int mc13892_sw_regulator_set_voltage(struct regulator_dev *rdev,
>  	if (ret)
>  		goto err;
>  
> -	if (value > 1375)
> +	if (value > 1375000)
>  		hi = 1;
> -	else if (value < 1100)
> +	else if (value < 1100000)
>  		hi = 0;
>  	else
>  		hi = valread & MC13892_SWITCHERS0_SWxHI;

Applied.

      reply	other threads:[~2011-05-16 20:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 13:54 [PATCH v2] regulator: mc13892: Fix voltage unit in test case Fabio Estevam
2011-05-16 20:19 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305577140.3156.13.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).