* [PATCH v2] regulator: mc13892: Fix voltage unit in test case.
@ 2011-05-16 13:54 Fabio Estevam
2011-05-16 20:19 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2011-05-16 13:54 UTC (permalink / raw)
To: linux-arm-kernel
Voltage values should be expressed in microvolts, not in milivolts.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Ranjani Vaidyanathan <ra5478@freescale.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
Changes since v1:
- Rebase it on top of Liam's regulator for-next tree.
drivers/regulator/mc13892-regulator.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index 73347c8..6fffe67 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -453,9 +453,9 @@ static int mc13892_sw_regulator_set_voltage(struct regulator_dev *rdev,
if (ret)
goto err;
- if (value > 1375)
+ if (value > 1375000)
hi = 1;
- else if (value < 1100)
+ else if (value < 1100000)
hi = 0;
else
hi = valread & MC13892_SWITCHERS0_SWxHI;
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2] regulator: mc13892: Fix voltage unit in test case.
2011-05-16 13:54 [PATCH v2] regulator: mc13892: Fix voltage unit in test case Fabio Estevam
@ 2011-05-16 20:19 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2011-05-16 20:19 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2011-05-16 at 10:54 -0300, Fabio Estevam wrote:
> Voltage values should be expressed in microvolts, not in milivolts.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Ranjani Vaidyanathan <ra5478@freescale.com>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> Changes since v1:
>
> - Rebase it on top of Liam's regulator for-next tree.
>
> drivers/regulator/mc13892-regulator.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
> index 73347c8..6fffe67 100644
> --- a/drivers/regulator/mc13892-regulator.c
> +++ b/drivers/regulator/mc13892-regulator.c
> @@ -453,9 +453,9 @@ static int mc13892_sw_regulator_set_voltage(struct regulator_dev *rdev,
> if (ret)
> goto err;
>
> - if (value > 1375)
> + if (value > 1375000)
> hi = 1;
> - else if (value < 1100)
> + else if (value < 1100000)
> hi = 0;
> else
> hi = valread & MC13892_SWITCHERS0_SWxHI;
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-16 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-16 13:54 [PATCH v2] regulator: mc13892: Fix voltage unit in test case Fabio Estevam
2011-05-16 20:19 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).