[PATCH] mioa701: move gpio-pullup functionality to gpio-vbus

[PATCH] mioa701: move gpio-pullup functionality to gpio-vbus

[Dmitry Eremin-Solenikov]

gpio-vbus can (and should?) handle D+ pullup gpio for us. Move gpio-pullup handling
to gpio-vbus and stop providing udc_info as it's empty now.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 arch/arm/mach-pxa/mioa701.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c
index 05f9efb..239d81e 100644
--- a/arch/arm/mach-pxa/mioa701.c
+++ b/arch/arm/mach-pxa/mioa701.c
@@ -402,14 +402,10 @@ static void gsm_exit(void)
 /*
  * USB UDC
  */
-static struct pxa2xx_udc_mach_info mioa701_udc_info = {
-	.gpio_pullup	  = GPIO22_USB_ENABLE,
-};
-
 struct gpio_vbus_mach_info gpio_vbus_data = {
 	.gpio_vbus = GPIO13_nUSB_DETECT,
 	.gpio_vbus_inverted = 1,
-	.gpio_pullup = -1,
+	.gpio_pullup = GPIO22_USB_ENABLE,
 };
 
 /*
@@ -797,7 +793,6 @@ static void __init mioa701_machine_init(void)
 	pxa_set_fb_info(NULL, &mioa701_pxafb_info);
 	pxa_set_mci_info(&mioa701_mci_info);
 	pxa_set_keypad_info(&mioa701_keypad_info);
-	pxa_set_udc_info(&mioa701_udc_info);
 	pxa_set_ac97_info(&mioa701_ac97_info);
 	pm_power_off = mioa701_poweroff;
 	arm_pm_restart = mioa701_restart;
-- 
1.7.4.4

[PATCH] mioa701: move gpio-pullup functionality to gpio-vbus

[Robert Jarzmik]

On 05/18/2011 01:57 PM, Dmitry Eremin-Solenikov wrote:
> gpio-vbus can (and should?) handle D+ pullup gpio for us. Move gpio-pullup handling
> to gpio-vbus and stop providing udc_info as it's empty now.
No sorry, NAK.

As a matter of fact, even if gpio-vbus driver handles correctly the VBUS 
sensing and D+ line powering, it still lacks the suspend / resume 
handling to "disconnect the D+ line" on suspend and reconnect it on 
"resume". That's the reason I nack this patch, as for me, gpio-vbus and 
pxa27x-udc are not yet iso functional.

If I was provided proof that this is innoccuous (ie. there is no power 
draw possible in suspend, or that the resume procedure still works with 
gpio-vbus), then I'll ack the patch.

Cheers.

--
Robert

[PATCH] mioa701: move gpio-pullup functionality to gpio-vbus

[Dmitry Eremin-Solenikov]

On 5/20/11, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> On 05/18/2011 01:57 PM, Dmitry Eremin-Solenikov wrote:
>> gpio-vbus can (and should?) handle D+ pullup gpio for us. Move gpio-pullup
>> handling
>> to gpio-vbus and stop providing udc_info as it's empty now.
> No sorry, NAK.
>
> As a matter of fact, even if gpio-vbus driver handles correctly the VBUS
> sensing and D+ line powering, it still lacks the suspend / resume
> handling to "disconnect the D+ line" on suspend and reconnect it on
> "resume". That's the reason I nack this patch, as for me, gpio-vbus and
> pxa27x-udc are not yet iso functional.

gpio-vbus handles D+ line. It doesn't handle suspend.
BTW: do you mean system suspend (via pm->suspend), or USB suspend (via
USB SUSPEND interrupt)

> If I was provided proof that this is innoccuous (ie. there is no power
> draw possible in suspend, or that the resume procedure still works with
> gpio-vbus), then I'll ack the patch.

Hmm. I'll think about suspend issue (if you give me more info), but only you
can test the resume. Could you please test it?

-- 
With best wishes
Dmitry