From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 03/18] ARM: LPAE: Use unsigned long for __phys_to_virt and __virt_to_phys
Date: Tue, 24 May 2011 22:39:09 +0100 [thread overview]
Message-ID: <1306273164-18217-4-git-send-email-catalin.marinas@arm.com> (raw)
In-Reply-To: <1306273164-18217-1-git-send-email-catalin.marinas@arm.com>
The !CONFIG_ARM_PATCH_PHYS_VIRT case uses macros for __phys_to_virt and
__virt_to_phys but does not use any type casting. This causes compiler
warnings with LPAE where the phys_addr_t and dma_addr_t are 64-bit:
CC arch/arm/mm/dma-mapping.o
In file included from /work/Linux/linux-marc/include/linux/dma-mapping.h:93:0,
from /work/Linux/linux-marc/arch/arm/mm/dma-mapping.c:19:
/work/Linux/linux-marc/arch/arm/include/asm/dma-mapping.h: In function 'dma_to_virt':
/work/Linux/linux-marc/arch/arm/include/asm/dma-mapping.h:35:9: warning:
cast to pointer from integer of different size
Note that these macros are only valid for lowmem physical addresses
where the range is within 32-bit address range.
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
arch/arm/include/asm/memory.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
index 431077c..10e4b4c 100644
--- a/arch/arm/include/asm/memory.h
+++ b/arch/arm/include/asm/memory.h
@@ -194,8 +194,8 @@ static inline unsigned long __phys_to_virt(unsigned long x)
return t;
}
#else
-#define __virt_to_phys(x) ((x) - PAGE_OFFSET + PHYS_OFFSET)
-#define __phys_to_virt(x) ((x) - PHYS_OFFSET + PAGE_OFFSET)
+#define __virt_to_phys(x) ((unsigned long)(x) - PAGE_OFFSET + PHYS_OFFSET)
+#define __phys_to_virt(x) ((unsigned long)(x) - PHYS_OFFSET + PAGE_OFFSET)
#endif
#endif
next prev parent reply other threads:[~2011-05-24 21:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 21:39 [PATCH v6 00/18] ARM: Add support for the Large Physical Address Extensions Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 01/18] ARM: LPAE: Use long long printk format for displaying the pud Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 02/18] ARM: LPAE: add ISBs around MMU enabling code Catalin Marinas
2011-05-24 21:39 ` Catalin Marinas [this message]
2011-05-24 21:39 ` [PATCH v6 04/18] ARM: LPAE: Use PMD_(SHIFT|SIZE|MASK) instead of PGDIR_* Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 05/18] ARM: LPAE: Factor out 2-level page table definitions into separate files Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 06/18] ARM: LPAE: Add (pte|pmd|pgd|pgprot)val_t type definitions as u32 Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 07/18] ARM: LPAE: Use a mask for physical addresses in page table entries Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 08/18] ARM: LPAE: Introduce the 3-level page table format definitions Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 09/18] ARM: LPAE: Page table maintenance for the 3-level format Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 10/18] ARM: LPAE: MMU setup for the 3-level page table format Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 11/18] ARM: LPAE: Invalidate the TLB before freeing the PMD Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 12/18] ARM: LPAE: Add fault handling support Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 13/18] ARM: LPAE: Add context switching support Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 14/18] ARM: LPAE: Add identity mapping support for the 3-level page table format Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 15/18] ARM: LPAE: Use generic dma_addr_t type definition Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 16/18] ARM: LPAE: mark memory banks with start > ULONG_MAX as highmem Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 17/18] ARM: LPAE: add support for ATAG_MEM64 Catalin Marinas
2011-05-24 21:39 ` [PATCH v6 18/18] ARM: LPAE: Add the Kconfig entries Catalin Marinas
2011-05-24 23:56 ` [PATCH v6 00/18] ARM: Add support for the Large Physical Address Extensions David Brown
2011-05-25 0:44 ` Nicolas Pitre
2011-05-25 11:10 ` Arnd Bergmann
2011-05-25 11:22 ` Catalin Marinas
2011-05-25 12:43 ` Catalin Marinas
2011-05-25 8:33 ` Catalin Marinas
2011-07-01 16:24 ` Catalin Marinas
2011-07-02 12:19 ` Russell King - ARM Linux
2011-07-04 17:23 ` Catalin Marinas
2011-07-08 19:21 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306273164-18217-4-git-send-email-catalin.marinas@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).