From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Koul, Vinod) Date: Wed, 25 May 2011 13:49:53 +0530 Subject: [PATCH 1/5] dmaengine: add ep93xx DMA support In-Reply-To: References: Message-ID: <1306311593.30236.103.camel@vkoul-udesk3> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2011-05-25 at 10:39 +0200, Linus Walleij wrote: > 2011/5/22 Mika Westerberg : > > > The ep93xx DMA controller has 10 independent memory to peripheral (M2P) > > channels, and 2 dedicated memory to memory (M2M) channels. M2M channels can > > also be used by SPI and IDE to perform DMA transfers to/from their memory > > mapped FIFOs. > > No so much a review comment as an observation: I opposed the merge of the > EP93xx SPI driver in drivers/spi/ep93xx_spi.c on the grounds that it was close > enough to amba-pl022.c that it could use that driver instead. > > One of the arguments against was that you were going to do custom DMA > and stuff. Now you're using the DMAengine, so can you please reconsider > refactoring amba-pl022.c to suit your needs and you'll get DMA support for > free mor or less. Linus is the dma IP same as existing ones? In that case we shouldn't have a new driver for same IP. -- ~Vinod