Locking debug config in mxs_defconfig

Locking debug config in mxs_defconfig

[Shawn Guo]

Hi Wolfram,

When running image built from mxs_defconfig, we can see locking
warnings that Uwe reported before [1], because the debug locking
config options are turned on in defconfig.

You intended to mark this is something TODO?  Otherwise we can turn
them off until common clock sorts atomic/sleeping thing out?

[1] http://comments.gmane.org/gmane.linux.ports.arm.kernel/100744

-- 
Regards,
Shawn

[PATCH] ARM: mxs_defconfig: Remove locking debug config options

[Shawn Guo]

The amba-pl011 driver assumes that clk_enable/disable are atomic, but
currently it's not the case on mxs.  There are lock debug warnings
seen when serial console does power management.

The patch removes locking debug config options to get rid of the
warnings.  They can be turned on later when new clock framework sorts
the locking thing out.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 arch/arm/configs/mxs_defconfig |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
index db2cb7d..f9a54a6 100644
--- a/arch/arm/configs/mxs_defconfig
+++ b/arch/arm/configs/mxs_defconfig
@@ -116,8 +116,6 @@ CONFIG_DEBUG_KERNEL=y
 CONFIG_LOCKUP_DETECTOR=y
 CONFIG_DETECT_HUNG_TASK=y
 CONFIG_TIMER_STATS=y
-CONFIG_PROVE_LOCKING=y
-CONFIG_DEBUG_SPINLOCK_SLEEP=y
 CONFIG_DEBUG_INFO=y
 CONFIG_SYSCTL_SYSCALL_CHECK=y
 CONFIG_BLK_DEV_IO_TRACE=y
-- 
1.7.4.1

[PATCH] ARM: mxs_defconfig: Remove locking debug config options

[Uwe Kleine-König]

On Thu, May 26, 2011 at 02:26:43PM +0800, Shawn Guo wrote:
> The amba-pl011 driver assumes that clk_enable/disable are atomic, but
> currently it's not the case on mxs.  There are lock debug warnings
> seen when serial console does power management.
> 
> The patch removes locking debug config options to get rid of the
> warnings.  They can be turned on later when new clock framework sorts
> the locking thing out.
I'd keep the debug messages enabled. Just because you disable them the
problem isn't gone. This way it's a bit more certain that it gets fixed
...

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH] ARM: mxs_defconfig: Remove locking debug config options

[Shawn Guo]

On Thu, May 26, 2011 at 02:00:55PM +0200, Uwe Kleine-K?nig wrote:
> On Thu, May 26, 2011 at 02:26:43PM +0800, Shawn Guo wrote:
> > The amba-pl011 driver assumes that clk_enable/disable are atomic, but
> > currently it's not the case on mxs.  There are lock debug warnings
> > seen when serial console does power management.
> > 
> > The patch removes locking debug config options to get rid of the
> > warnings.  They can be turned on later when new clock framework sorts
> > the locking thing out.
> I'd keep the debug messages enabled. Just because you disable them the
> problem isn't gone. This way it's a bit more certain that it gets fixed
> ...
> 
This is a well known problem.  Migrating to new clock framework is on
top of my TODO list, and I will do once it comes.  Before that, all
we can do is looking at the warning message every single time we boot
the kernel.  It is not helping anything but getting valuable debugging
message invisible in the flooding lock warnings.

-- 
Regards,
Shawn