* [PATCH] pxa: correct icip irq handling
@ 2011-05-28 21:28 Dmitry Eremin-Solenikov
2011-05-31 5:31 ` Eric Miao
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Eremin-Solenikov @ 2011-05-28 21:28 UTC (permalink / raw)
To: linux-arm-kernel
IRQ handling on PXA25x is broken if PXA_HAVE_ISA_IRQS is enabled (then
all PXA irqs are shifted to start from 16, but icip_handle_irq doesn't
work in this case. Use PXA_IRQ to correct IRQ numbers in icip_handle_irq.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
arch/arm/mach-pxa/irq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
index 858e287..d9cab3b 100644
--- a/arch/arm/mach-pxa/irq.c
+++ b/arch/arm/mach-pxa/irq.c
@@ -141,7 +141,7 @@ asmlinkage void __exception_irq_entry icip_handle_irq(struct pt_regs *regs)
if (mask == 0)
break;
- asm_do_IRQ(fls(mask) - 1, regs);
+ asm_do_IRQ(PXA_IRQ(fls(mask) - 1), regs);
} while (1);
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] pxa: correct icip irq handling
2011-05-28 21:28 [PATCH] pxa: correct icip irq handling Dmitry Eremin-Solenikov
@ 2011-05-31 5:31 ` Eric Miao
0 siblings, 0 replies; 2+ messages in thread
From: Eric Miao @ 2011-05-31 5:31 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, May 29, 2011 at 5:28 AM, Dmitry Eremin-Solenikov
<dbaryshkov@gmail.com> wrote:
> IRQ handling on PXA25x is broken if PXA_HAVE_ISA_IRQS is enabled (then
> all PXA irqs are shifted to start from 16, but icip_handle_irq doesn't
> work in this case. Use PXA_IRQ to correct IRQ numbers in icip_handle_irq.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Applied. Unfortunately, Russell didn't seem to have pulled, so we may need
further address the issues he pointed out.
> ---
> ?arch/arm/mach-pxa/irq.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
> index 858e287..d9cab3b 100644
> --- a/arch/arm/mach-pxa/irq.c
> +++ b/arch/arm/mach-pxa/irq.c
> @@ -141,7 +141,7 @@ asmlinkage void __exception_irq_entry icip_handle_irq(struct pt_regs *regs)
> ? ? ? ? ? ? ? ?if (mask == 0)
> ? ? ? ? ? ? ? ? ? ? ? ?break;
>
> - ? ? ? ? ? ? ? asm_do_IRQ(fls(mask) - 1, regs);
> + ? ? ? ? ? ? ? asm_do_IRQ(PXA_IRQ(fls(mask) - 1), regs);
> ? ? ? ?} while (1);
> ?}
>
> --
> 1.7.4.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-31 5:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-28 21:28 [PATCH] pxa: correct icip irq handling Dmitry Eremin-Solenikov
2011-05-31 5:31 ` Eric Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).