linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jic23@cam.ac.uk (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3 V2] pxa2xx pcmcia - vpac glue code fix and trizeps cleanup.
Date: Mon,  6 Jun 2011 15:24:12 +0100	[thread overview]
Message-ID: <1307370255-15963-1-git-send-email-jic23@cam.ac.uk> (raw)

V2 - actually put the right device name in the patch titles (thanks Marc)
     add some more trivial cleanup to trizeps (patch 3)

Original message:

The first patch looks like a simple bug.
The second removes an ifdef that doesn't do anything.

I was looking through this code with a vague view to simplifying it.
Why do pxa2xx and sa1100 require lots of platform glue when others
subarches do not?

On the second one, it looks to me like all those ifdefs could be
trivially removed.

Otherwise, a lot of these bits of glue code could be greatly reduced
by introducing a few default functions and const structures.  Anyone
bored enough to do it?

I might carry on dabbling if people familiar with all these boards
are happy to review.

Jonathan


Jonathan Cameron (3):
  pxa2xx vpac: pcmcia - free gpios on exist rather than requesting them
    again.
  pxa2xx trizeps4: pcmcia remove unnecessary ifdefs
  pxa2xx trizeps4 pcmcia: code cleanup

 drivers/pcmcia/pxa2xx_trizeps4.c |   95 +++++++++++++++++--------------------
 drivers/pcmcia/pxa2xx_vpac270.c  |    4 +-
 2 files changed, 46 insertions(+), 53 deletions(-)

-- 
1.7.3.4

             reply	other threads:[~2011-06-06 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 14:24 Jonathan Cameron [this message]
2011-06-06 14:24 ` [PATCH 1/3] pxa2xx vpac: pcmcia - free gpios on exist rather than requesting them again Jonathan Cameron
2011-06-06 14:43   ` Marek Vasut
2011-06-15 13:07     ` Eric Miao
2011-06-06 14:24 ` [PATCH 2/3] pxa2xx trizeps4: pcmcia remove unnecessary ifdefs Jonathan Cameron
2011-06-06 14:44   ` Marek Vasut
2011-06-15 13:09     ` Eric Miao
2011-06-06 14:24 ` [PATCH 3/3] pxa2xx trizeps4 pcmcia: code cleanup Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307370255-15963-1-git-send-email-jic23@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).