From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] mmc: sdhci-esdhc-imx: remove "WP" from flag ESDHC_FLAG_GPIO_FOR_CD_WP
Date: Fri, 10 Jun 2011 18:42:51 +0800 [thread overview]
Message-ID: <1307702572-22066-4-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1307702572-22066-1-git-send-email-shawn.guo@linaro.org>
The use of flag ESDHC_FLAG_GPIO_FOR_CD_WP is all CD related. It does
not necessarily need to bother WP in the flag name.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/mmc/host/sdhci-esdhc-imx.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 94097c0..79b7a9a 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -29,7 +29,7 @@
#define SDHCI_VENDOR_SPEC 0xC0
#define SDHCI_VENDOR_SPEC_SDIO_QUIRK 0x00000002
-#define ESDHC_FLAG_GPIO_FOR_CD_WP (1 << 0)
+#define ESDHC_FLAG_GPIO_FOR_CD (1 << 0)
/*
* The CMDTYPE of the CMD register (offset 0xE) should be set to
* "11" when the STOP CMD12 is issued on imx53 to abort one
@@ -77,7 +77,7 @@ static u32 esdhc_readl_le(struct sdhci_host *host, int reg)
u32 val = readl(host->ioaddr + reg);
if (unlikely((reg == SDHCI_PRESENT_STATE)
- && (imx_data->flags & ESDHC_FLAG_GPIO_FOR_CD_WP))) {
+ && (imx_data->flags & ESDHC_FLAG_GPIO_FOR_CD))) {
struct esdhc_platform_data *boarddata =
host->mmc->parent->platform_data;
@@ -99,7 +99,7 @@ static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg)
struct pltfm_imx_data *imx_data = pltfm_host->priv;
if (unlikely((reg == SDHCI_INT_ENABLE || reg == SDHCI_SIGNAL_ENABLE)
- && (imx_data->flags & ESDHC_FLAG_GPIO_FOR_CD_WP)))
+ && (imx_data->flags & ESDHC_FLAG_GPIO_FOR_CD)))
/*
* these interrupts won't work with a custom card_detect gpio
* (only applied to mx25/35)
@@ -308,7 +308,7 @@ static int __devinit sdhci_esdhc_imx_probe(struct platform_device *pdev)
goto no_card_detect_irq;
}
- imx_data->flags |= ESDHC_FLAG_GPIO_FOR_CD_WP;
+ imx_data->flags |= ESDHC_FLAG_GPIO_FOR_CD;
/* Now we have a working card_detect again */
host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
}
--
1.7.4.1
next prev parent reply other threads:[~2011-06-10 10:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 10:42 [PATCH 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5 Shawn Guo
2011-06-10 10:42 ` [PATCH 1/4] mmc: sdhci: fix interrupt storm from card detection Shawn Guo
2011-06-14 9:24 ` Wolfram Sang
2011-06-14 11:55 ` Shawn Guo
2011-06-14 12:02 ` Wolfram Sang
2011-06-14 12:24 ` Shawn Guo
2011-06-10 10:42 ` [PATCH 2/4] mmc: sdhci-esdhc-imx: SDHCI_CARD_PRESENT does not get cleared Shawn Guo
2011-06-14 9:22 ` Wolfram Sang
2011-06-10 10:42 ` Shawn Guo [this message]
2011-06-14 9:28 ` [PATCH 3/4] mmc: sdhci-esdhc-imx: remove "WP" from flag ESDHC_FLAG_GPIO_FOR_CD_WP Wolfram Sang
2011-06-14 11:51 ` Shawn Guo
2011-06-10 10:42 ` [PATCH 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support Shawn Guo
2011-06-11 9:30 ` Arnaud Patard (Rtp)
2011-06-11 11:50 ` Shawn Guo
2011-06-11 11:59 ` Arnaud Patard (Rtp)
2011-06-11 13:16 ` Shawn Guo
2011-06-11 19:21 ` Arnaud Patard (Rtp)
2011-06-14 6:47 ` [PATCH v2 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5 Shawn Guo
2011-06-14 9:51 ` Wolfram Sang
2011-06-14 13:06 ` Shawn Guo
2011-06-14 13:55 ` Wolfram Sang
2011-06-15 3:10 ` Shawn Guo
2011-06-15 10:33 ` Shawn Guo
2011-06-15 10:44 ` Wolfram Sang
2011-06-14 6:48 ` [PATCH 0/4] Extend sdhci-esdhc-imx " Shawn Guo
2011-06-14 11:13 ` Arnaud Patard (Rtp)
2011-06-14 11:39 ` Shawn Guo
2011-06-14 13:12 ` Shawn Guo
2011-06-14 14:29 ` Arnaud Patard (Rtp)
2011-06-15 3:13 ` Shawn Guo
2011-06-16 18:32 ` Arnaud Patard (Rtp)
2011-06-20 10:41 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307702572-22066-4-git-send-email-shawn.guo@linaro.org \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).