linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: gic: Allow gic arch extensions to provide irqchip flags
@ 2011-06-13  0:45 Colin Cross
  2011-07-10  0:03 ` Santosh Shilimkar
  0 siblings, 1 reply; 3+ messages in thread
From: Colin Cross @ 2011-06-13  0:45 UTC (permalink / raw)
  To: linux-arm-kernel

Tegra can benefit from the IRQCHIP_MASK_ON_SUSPEND flag, allow it
to be passed to the gic irq chip.

Signed-off-by: Colin Cross <ccross@android.com>
---
 arch/arm/common/gic.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
index 8d62e07..a6c28a0 100644
--- a/arch/arm/common/gic.c
+++ b/arch/arm/common/gic.c
@@ -576,6 +576,7 @@ void __init gic_init(unsigned int gic_nr, unsigned int irq_start,
 	if (gic_nr == 0)
 		gic_cpu_base_addr = cpu_base;
 
+	gic_chip.flags |= gic_arch_extn.flags;
 	gic_dist_init(gic, irq_start);
 	gic_cpu_init(gic);
 	gic_cpu_pm_init(gic);
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: gic: Allow gic arch extensions to provide irqchip flags
  2011-06-13  0:45 [PATCH] ARM: gic: Allow gic arch extensions to provide irqchip flags Colin Cross
@ 2011-07-10  0:03 ` Santosh Shilimkar
  2011-07-10  0:08   ` Colin Cross
  0 siblings, 1 reply; 3+ messages in thread
From: Santosh Shilimkar @ 2011-07-10  0:03 UTC (permalink / raw)
  To: linux-arm-kernel

On 6/12/2011 5:45 PM, Colin Cross wrote:
> Tegra can benefit from the IRQCHIP_MASK_ON_SUSPEND flag, allow it
> to be passed to the gic irq chip.
>
> Signed-off-by: Colin Cross<ccross@android.com>

I missed this patch. Looks good to me and I think can
be merged in rc as well.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

> ---
>   arch/arm/common/gic.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
> index 8d62e07..a6c28a0 100644
> --- a/arch/arm/common/gic.c
> +++ b/arch/arm/common/gic.c
> @@ -576,6 +576,7 @@ void __init gic_init(unsigned int gic_nr, unsigned int irq_start,
>   	if (gic_nr == 0)
>   		gic_cpu_base_addr = cpu_base;
>
> +	gic_chip.flags |= gic_arch_extn.flags;
>   	gic_dist_init(gic, irq_start);
>   	gic_cpu_init(gic);
>   	gic_cpu_pm_init(gic);

Russell,
Any thoughts on this fix?

Regards
Santosh

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: gic: Allow gic arch extensions to provide irqchip flags
  2011-07-10  0:03 ` Santosh Shilimkar
@ 2011-07-10  0:08   ` Colin Cross
  0 siblings, 0 replies; 3+ messages in thread
From: Colin Cross @ 2011-07-10  0:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Jul 9, 2011 at 5:03 PM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
> On 6/12/2011 5:45 PM, Colin Cross wrote:
>>
>> Tegra can benefit from the IRQCHIP_MASK_ON_SUSPEND flag, allow it
>> to be passed to the gic irq chip.
>>
>> Signed-off-by: Colin Cross<ccross@android.com>
>
> I missed this patch. Looks good to me and I think can
> be merged in rc as well.
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

There is no need for this in an rc unless another patch destined for
rc needs to set the flags, which is unlikely at this point.

>> ---
>> ?arch/arm/common/gic.c | ? ?1 +
>> ?1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
>> index 8d62e07..a6c28a0 100644
>> --- a/arch/arm/common/gic.c
>> +++ b/arch/arm/common/gic.c
>> @@ -576,6 +576,7 @@ void __init gic_init(unsigned int gic_nr, unsigned int
>> irq_start,
>> ? ? ? ?if (gic_nr == 0)
>> ? ? ? ? ? ? ? ?gic_cpu_base_addr = cpu_base;
>>
>> + ? ? ? gic_chip.flags |= gic_arch_extn.flags;
>> ? ? ? ?gic_dist_init(gic, irq_start);
>> ? ? ? ?gic_cpu_init(gic);
>> ? ? ? ?gic_cpu_pm_init(gic);
>
> Russell,
> Any thoughts on this fix?
>
> Regards
> Santosh
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-07-10  0:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-13  0:45 [PATCH] ARM: gic: Allow gic arch extensions to provide irqchip flags Colin Cross
2011-07-10  0:03 ` Santosh Shilimkar
2011-07-10  0:08   ` Colin Cross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).