From: saeed@marvell.com (Saeed Bishara)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: realview, vexpress: fix section mismatch from platform_cpu_die() to pen_release
Date: Tue, 14 Jun 2011 16:28:52 +0300 [thread overview]
Message-ID: <1308058132-32058-1-git-send-email-saeed@marvell.com> (raw)
This patch fixes the following false section mismatch warning, this function used
only in CONFIG_HOTPLUG_CPU, and in this configuration, the cpuinit section will not
be freed, so it's ok to reference pen_release.
WARNING: vmlinux.o(.text+0x12484): Section mismatch in reference from the function platform_cpu_die() to the variable .cpuinit.data:pen_release
The function platform_cpu_die() references
the variable __cpuinitdata pen_release.
This is often because platform_cpu_die lacks a __cpuinitdata
annotation or the annotation of pen_release is wrong.
Signed-off-by: Saeed Bishara <saeed@marvell.com>
---
arch/arm/mach-realview/hotplug.c | 2 +-
arch/arm/mach-vexpress/hotplug.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-realview/hotplug.c b/arch/arm/mach-realview/hotplug.c
index a87523d..44841c6 100644
--- a/arch/arm/mach-realview/hotplug.c
+++ b/arch/arm/mach-realview/hotplug.c
@@ -97,7 +97,7 @@ int platform_cpu_kill(unsigned int cpu)
*
* Called with IRQs disabled
*/
-void platform_cpu_die(unsigned int cpu)
+void __ref platform_cpu_die(unsigned int cpu)
{
int spurious = 0;
diff --git a/arch/arm/mach-vexpress/hotplug.c b/arch/arm/mach-vexpress/hotplug.c
index ea4cbfb..0436fcf 100644
--- a/arch/arm/mach-vexpress/hotplug.c
+++ b/arch/arm/mach-vexpress/hotplug.c
@@ -98,7 +98,7 @@ int platform_cpu_kill(unsigned int cpu)
*
* Called with IRQs disabled
*/
-void platform_cpu_die(unsigned int cpu)
+void __ref platform_cpu_die(unsigned int cpu)
{
int spurious = 0;
--
1.7.4.1
next reply other threads:[~2011-06-14 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 13:28 Saeed Bishara [this message]
2011-06-19 7:54 ` [PATCH] ARM: realview, vexpress: fix section mismatch from platform_cpu_die() to pen_release saeed bishara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308058132-32058-1-git-send-email-saeed@marvell.com \
--to=saeed@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).