public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: gxt@mprc.pku.edu.cn (Guan Xuetao)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC,PATCH] Cleanup PC parallel port Kconfig
Date: Wed, 15 Jun 2011 09:24:06 +0800	[thread overview]
Message-ID: <1308101046.4727.10.camel@epip-laptop> (raw)
In-Reply-To: <20110614190850.GA13526@linux-mips.org>

On Tue, 2011-06-14 at 20:08 +0100, Ralf Baechle wrote:
> The PC parallel port Kconfig as acquired one of those messy terms to
> describe it's architecture dependencies:
> 
>        depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \
>                (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN
> 
> This isn't just ugly - it also almost certainly describes the dependencies
> too coarse grainedly.  This is an attempt at cleaing the mess up.
> 
> I tried to faithfully aproximate the old behaviour but the existing
> behaviour seems inacurate if not wrong for some architectures or platforms.
> To improve on this I rely on comments from other arch and platforms
> maintainers.  Any system that can take PCI multi-IO card or has a PC-style
> parallel port on the mainboard should probably should now do a
> select HAVE_PC_PARPORT.  And some arch Kconfig files should further
> restrict the use of HAVE_PC_PARPORT to only those platforms that actually
> need it.
> 
> Thanks,
> 
>   Ralf

> diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
> index e57dcce..3832e7e 100644
> --- a/arch/unicore32/Kconfig
> +++ b/arch/unicore32/Kconfig
> @@ -8,6 +8,7 @@ config UNICORE32
>  	select HAVE_KERNEL_BZIP2
>  	select HAVE_KERNEL_LZO
>  	select HAVE_KERNEL_LZMA
> +	select HAVE_PC_PARPORT
>  	select GENERIC_FIND_FIRST_BIT
>  	select GENERIC_IRQ_PROBE
>  	select GENERIC_IRQ_SHOW
In UniCore32, only some debug-boards need to support parport.
So I'd like to add HAVE_PC_PARPORT and related configs to certian
*_defconfig, but not in Kconfig.

Thanks Ralf.

Guan Xuetao

      parent reply	other threads:[~2011-06-15  1:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 19:08 [RFC,PATCH] Cleanup PC parallel port Kconfig Ralf Baechle
2011-06-14 20:22 ` Arnd Bergmann
2011-06-14 20:25 ` H. Peter Anvin
2011-06-14 21:33   ` Arnd Bergmann
2011-06-15  4:30     ` H. Peter Anvin
2011-06-15  7:47       ` Russell King - ARM Linux
2011-06-15 15:08         ` H. Peter Anvin
2011-06-15 15:21           ` Russell King - ARM Linux
2011-06-15  9:46       ` Arnd Bergmann
2011-06-15 11:24         ` Geert Uytterhoeven
2011-06-14 22:34   ` Ralf Baechle
2011-06-15  4:18     ` H. Peter Anvin
2011-06-15  4:40       ` Guenter Roeck
2011-06-15  5:43         ` H. Peter Anvin
2011-06-15  8:34       ` Ralf Baechle
2011-06-15 14:36         ` Guenter Roeck
2011-06-14 20:32 ` Geert Uytterhoeven
2011-06-14 22:08 ` Luck, Tony
2011-06-15  4:31   ` H. Peter Anvin
2011-06-15  7:39     ` Russell King - ARM Linux
2011-06-15 15:16       ` H. Peter Anvin
2011-06-15  1:24 ` Guan Xuetao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308101046.4727.10.camel@epip-laptop \
    --to=gxt@mprc.pku.edu.cn \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox