public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: dbaryshkov@gmail.com (Dmitry Eremin-Solenikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] collie: don't read GPSR
Date: Fri, 17 Jun 2011 18:11:32 +0400	[thread overview]
Message-ID: <1308319892-13057-1-git-send-email-dbaryshkov@gmail.com> (raw)

On StrongARM GPSR is write-only according to docs, so don't read from
it. Just set the required GPIO.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 arch/arm/mach-sa1100/collie.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-sa1100/collie.c b/arch/arm/mach-sa1100/collie.c
index f28025e..3f32ba2 100644
--- a/arch/arm/mach-sa1100/collie.c
+++ b/arch/arm/mach-sa1100/collie.c
@@ -339,7 +339,7 @@ static void __init collie_init(void)
 
 	PCFR = PCFR_OPDE;
 
-	GPSR |= _COLLIE_GPIO_UCB1x00_RESET;
+	GPSR = _COLLIE_GPIO_UCB1x00_RESET;
 
 
 	platform_scoop_config = &collie_pcmcia_config;
-- 
1.7.5.3

             reply	other threads:[~2011-06-17 14:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-17 14:11 Dmitry Eremin-Solenikov [this message]
2011-06-17 14:49 ` [PATCH] collie: don't read GPSR Lothar Waßmann
2011-06-17 15:07 ` Eric Miao
2011-06-17 15:35   ` Dmitry Eremin-Solenikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308319892-13057-1-git-send-email-dbaryshkov@gmail.com \
    --to=dbaryshkov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox