From: premi@ti.com (Sanjeev Premi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] omap3: beagle: Use GPTIMER1 for clockevents
Date: Mon, 27 Jun 2011 16:06:49 +0530 [thread overview]
Message-ID: <1309171009-8075-1-git-send-email-premi@ti.com> (raw)
From: Hrishikesh Bhandiwad <hrishikesh.b@ti.com>
Present current selection of the GPTIMER on Beagleboard
was result of a hardware issue in early versions of the
Beagleboards (Ax and B1 thru B4). [1][2]
Its been long since the hardware issue has been fixed.
This patch uses GPTIMER 1 for all newer board revisions
incl. Beagleboard XM.
Also, the clock source for GPTIMER12 is much less frequency
stable than clock sources for GPTIMER1. Using GPTIMER12 can
result in major time skew over a fairly short interval.
[1] http://thread.gmane.org/gmane.comp.hardware.beagleboard.general/91
[2] Errata #7 at http://elinux.org/BeagleBoard#Errata
Signed-off-by: Sanjeev Premi <premi@ti.com>
Reviewed-by: Paul Walmsley <paul@pwsan.com>
Cc: Hrishikesh Bhandiwad <hrishikesh.b@ti.com>
Cc: Thomas Weber <weber@corscience.de>
Cc: Jason Lam <lzg@ema-tech.com>
Cc: Gregoire Gentil <gregoire@gentil.com>
---
Changes since v1:
* Updated description with details from Paul Walmsley.
* Changed author to Hrishikesh.
* Expanded cc: to include original authors for other
boards that are still using GPTIMER12.
arch/arm/mach-omap2/board-omap3beagle.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 4b113b2..edc1596 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -509,7 +509,10 @@ static void __init omap3_beagle_init_irq(void)
{
omap_init_irq();
#ifdef CONFIG_OMAP_32K_TIMER
- omap2_gp_clockevent_set_gptimer(12);
+ if (omap3_beagle_version == OMAP3BEAGLE_BOARD_AXBX)
+ omap2_gp_clockevent_set_gptimer(12);
+ else
+ omap2_gp_clockevent_set_gptimer(1);
#endif
}
--
1.7.2.2
next reply other threads:[~2011-06-27 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 10:36 Sanjeev Premi [this message]
2011-06-27 11:15 ` [PATCHv2] omap3: beagle: Use GPTIMER1 for clockevents Tony Lindgren
2011-06-27 12:12 ` Premi, Sanjeev
2011-06-27 12:31 ` Tony Lindgren
2011-06-27 13:28 ` Premi, Sanjeev
2011-06-27 18:00 ` Tony Lindgren
2011-06-27 19:04 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309171009-8075-1-git-send-email-premi@ti.com \
--to=premi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox