* [PATCH v2 1/2] OMAP: 4430SDP: Register the card detect GPIO properly
@ 2011-06-29 2:14 Silesh C V
2011-06-29 2:14 ` [PATCH v2 2/2] OMAP: HSMMC: Fix GPIO muxing Silesh C V
0 siblings, 1 reply; 2+ messages in thread
From: Silesh C V @ 2011-06-29 2:14 UTC (permalink / raw)
To: linux-arm-kernel
Without this the HSMMC driver takes GPIO 0 to be the card detect gpio
and requests/configures it. This will give rise to issues when another
driver needs to use GPIO 0. On 4430SDP, the card detection is through
TWL 6030.
Signed-off-by: Silesh C V <silesh@ti.com>
---
Changes for v2 :
- Made it a series to make sure this one goes before the mux fix.
arch/arm/mach-omap2/board-4430sdp.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
index 63de2d3..7a1460f 100644
--- a/arch/arm/mach-omap2/board-4430sdp.c
+++ b/arch/arm/mach-omap2/board-4430sdp.c
@@ -327,6 +327,7 @@ static struct omap2_hsmmc_info mmc[] = {
{
.mmc = 1,
.caps = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
+ .gpio_cd = -EINVAL,
.gpio_wp = -EINVAL,
},
{} /* Terminator */
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2 2/2] OMAP: HSMMC: Fix GPIO muxing
2011-06-29 2:14 [PATCH v2 1/2] OMAP: 4430SDP: Register the card detect GPIO properly Silesh C V
@ 2011-06-29 2:14 ` Silesh C V
0 siblings, 0 replies; 2+ messages in thread
From: Silesh C V @ 2011-06-29 2:14 UTC (permalink / raw)
To: linux-arm-kernel
Use generic gpio call to check the validity of the gpio. Note that
this includes gpio 0 also which was missing before.
Signed-off-by: Silesh C V <silesh@ti.com>
---
arch/arm/mach-omap2/hsmmc.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c
index 66868c5..a9b45c7 100644
--- a/arch/arm/mach-omap2/hsmmc.c
+++ b/arch/arm/mach-omap2/hsmmc.c
@@ -13,6 +13,7 @@
#include <linux/slab.h>
#include <linux/string.h>
#include <linux/delay.h>
+#include <linux/gpio.h>
#include <mach/hardware.h>
#include <plat/mmc.h>
#include <plat/omap-pm.h>
@@ -213,12 +214,10 @@ static int nop_mmc_set_power(struct device *dev, int slot, int power_on,
static inline void omap_hsmmc_mux(struct omap_mmc_platform_data *mmc_controller,
int controller_nr)
{
- if ((mmc_controller->slots[0].switch_pin > 0) && \
- (mmc_controller->slots[0].switch_pin < OMAP_MAX_GPIO_LINES))
+ if (gpio_is_valid(mmc_controller->slots[0].switch_pin))
omap_mux_init_gpio(mmc_controller->slots[0].switch_pin,
OMAP_PIN_INPUT_PULLUP);
- if ((mmc_controller->slots[0].gpio_wp > 0) && \
- (mmc_controller->slots[0].gpio_wp < OMAP_MAX_GPIO_LINES))
+ if (gpio_is_valid(mmc_controller->slots[0].gpio_wp))
omap_mux_init_gpio(mmc_controller->slots[0].gpio_wp,
OMAP_PIN_INPUT_PULLUP);
if (cpu_is_omap34xx()) {
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-29 2:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-29 2:14 [PATCH v2 1/2] OMAP: 4430SDP: Register the card detect GPIO properly Silesh C V
2011-06-29 2:14 ` [PATCH v2 2/2] OMAP: HSMMC: Fix GPIO muxing Silesh C V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).