linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: mxs-dma: skip request_irq for NO_IRQ
Date: Thu, 30 Jun 2011 16:06:33 +0800	[thread overview]
Message-ID: <1309421193-7785-1-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <20110630052855.GE25931@S2100-06.ap.freescale.net>

In general, the mxs-dma users get separate irq for each channel,
but gpmi is special one which has only one irq shared by all gpmi
channels.  It causes mxs_dma channel allocation function fail for
all other gpmi channels except the first one calling into the
function.

The patch gets request_irq call skipped for NO_IRQ case, and leaves
this gpmi specific quirk to gpmi driver to sort out.  It will fix
above problem if gpmi driver sets chan_irq as gpmi irq for only one
channel and NO_IRQ for all the rest channels.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
---
 drivers/dma/mxs-dma.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index 88aad4f..2870d91 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -327,10 +327,12 @@ static int mxs_dma_alloc_chan_resources(struct dma_chan *chan)
 
 	memset(mxs_chan->ccw, 0, PAGE_SIZE);
 
-	ret = request_irq(mxs_chan->chan_irq, mxs_dma_int_handler,
-				0, "mxs-dma", mxs_dma);
-	if (ret)
-		goto err_irq;
+	if (mxs_chan->chan_irq != NO_IRQ) {
+		ret = request_irq(mxs_chan->chan_irq, mxs_dma_int_handler,
+					0, "mxs-dma", mxs_dma);
+		if (ret)
+			goto err_irq;
+	}
 
 	ret = clk_enable(mxs_dma->clk);
 	if (ret)
-- 
1.7.4.1

  reply	other threads:[~2011-06-30  8:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29  8:24 [PATCH v7 0/3] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-06-29  8:24 ` Huang Shijie
2011-06-29  8:24 ` [PATCH v7 1/3] MTD : add the common code for GPMI-NFC controller driver Huang Shijie
2011-06-29 10:06   ` Wolfram Sang
2011-06-29 10:33     ` Wolfram Sang
2011-06-29 10:46       ` Huang Shijie
2011-06-29 12:29         ` Wolfram Sang
2011-06-29 12:42           ` Russell King - ARM Linux
2011-06-29 12:49             ` Wolfram Sang
2011-06-29 14:00           ` Shawn Guo
2011-06-29 14:15             ` Wolfram Sang
2011-06-29 14:37               ` Shawn Guo
2011-06-30  4:46                 ` Wolfram Sang
2011-06-30  5:28                   ` Shawn Guo
2011-06-30  8:06                     ` Shawn Guo [this message]
2011-07-07  0:15                       ` [PATCH] dmaengine: mxs-dma: skip request_irq for NO_IRQ Shawn Guo
2011-07-07  2:06                         ` Vinod Koul
2011-07-07  3:24                           ` Shawn Guo
2011-07-07  3:23                             ` Huang Shijie
2011-07-13 23:31                             ` Koul, Vinod
2011-06-29 12:38   ` [PATCH v7 1/3] MTD : add the common code for GPMI-NFC controller driver Russell King - ARM Linux
2011-06-30  1:50     ` Huang Shijie
2011-06-30 10:27   ` Wolfram Sang
2011-06-30 17:04     ` Wolfram Sang
2011-07-01  5:41       ` Artem Bityutskiy
2011-07-01  6:47         ` Huang Shijie
2011-06-29  8:24 ` [PATCH v7 2/3] MTD : add support for imx23 and imx28 Huang Shijie
2011-06-29  8:24 ` [PATCH v7 3/3] MTD : add GPMI-NFC driver in the config and Makefile Huang Shijie
2011-06-30 10:40 ` [PATCH v7 0/3] add the GPMI controller driver for IMX23/IMX28 Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309421193-7785-1-git-send-email-shawn.guo@linaro.org \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).