linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: DMA: Silence declared inside parameter list warning for !CONFIG_MMU
@ 2011-07-04  8:12 Axel Lin
  2011-07-06 20:31 ` Russell King - ARM Linux
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-07-04  8:12 UTC (permalink / raw)
  To: linux-arm-kernel

Fix below warning, the struct dma_coherent_area takes no space if !CONFIG_MMU.

  CC      arch/arm/mm/dma-mapping.o
arch/arm/mm/dma-mapping.c:309: warning: 'struct dma_coherent_area' declared inside parameter list
arch/arm/mm/dma-mapping.c:309: warning: its scope is only this definition or declaration, which is probably not what you want
arch/arm/mm/dma-mapping.c:334: warning: 'struct dma_coherent_area' declared inside parameter list
arch/arm/mm/dma-mapping.c:374: warning: 'struct dma_coherent_area' declared inside parameter list

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 arch/arm/mm/dma-mapping.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 8089499..da3b33a 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -297,6 +297,8 @@ static void dma_free_area(void *cpu_addr, size_t size, struct dma_coherent_area
 #define coherent_wc_area NULL
 #define coherent_dma_area NULL
 
+struct dma_coherent_area { };
+
 void dma_coherent_reserve(void)
 {
 }
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: DMA: Silence declared inside parameter list warning for !CONFIG_MMU
  2011-07-04  8:12 [PATCH] ARM: DMA: Silence declared inside parameter list warning for !CONFIG_MMU Axel Lin
@ 2011-07-06 20:31 ` Russell King - ARM Linux
  0 siblings, 0 replies; 2+ messages in thread
From: Russell King - ARM Linux @ 2011-07-06 20:31 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jul 04, 2011 at 04:12:21PM +0800, Axel Lin wrote:
> Fix below warning, the struct dma_coherent_area takes no space if !CONFIG_MMU.
> 
>   CC      arch/arm/mm/dma-mapping.o
> arch/arm/mm/dma-mapping.c:309: warning: 'struct dma_coherent_area' declared inside parameter list
> arch/arm/mm/dma-mapping.c:309: warning: its scope is only this definition or declaration, which is probably not what you want
> arch/arm/mm/dma-mapping.c:334: warning: 'struct dma_coherent_area' declared inside parameter list
> arch/arm/mm/dma-mapping.c:374: warning: 'struct dma_coherent_area' declared inside parameter list
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Ok, can you put this in the patch system please?

Thanks.

> ---
>  arch/arm/mm/dma-mapping.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 8089499..da3b33a 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -297,6 +297,8 @@ static void dma_free_area(void *cpu_addr, size_t size, struct dma_coherent_area
>  #define coherent_wc_area NULL
>  #define coherent_dma_area NULL
>  
> +struct dma_coherent_area { };
> +
>  void dma_coherent_reserve(void)
>  {
>  }
> -- 
> 1.7.4.1
> 
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-07-06 20:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-04  8:12 [PATCH] ARM: DMA: Silence declared inside parameter list warning for !CONFIG_MMU Axel Lin
2011-07-06 20:31 ` Russell King - ARM Linux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).