linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dbaryshkov@gmail.com (Dmitry Eremin-Solenikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/15] mioa701: move gpio-pullup functionality to gpio-vbus
Date: Tue,  5 Jul 2011 17:08:39 +0400	[thread overview]
Message-ID: <1309871321-11305-14-git-send-email-dbaryshkov@gmail.com> (raw)
In-Reply-To: <1309871321-11305-1-git-send-email-dbaryshkov@gmail.com>

gpio-vbus can (and should?) handle D+ pullup gpio for us. Move
gpio-pullup handling to gpio-vbus and stop providing udc_info as it's
empty now. Also tell gpio-vbus that it should disable D+ pullup on
suspend, as did pxa27x_udc driver.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 arch/arm/mach-pxa/mioa701.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c
index d833a26..96c377c 100644
--- a/arch/arm/mach-pxa/mioa701.c
+++ b/arch/arm/mach-pxa/mioa701.c
@@ -402,14 +402,11 @@ static void gsm_exit(void)
 /*
  * USB UDC
  */
-static struct pxa2xx_udc_mach_info mioa701_udc_info = {
-	.gpio_pullup	  = GPIO22_USB_ENABLE,
-};
-
 struct gpio_vbus_mach_info gpio_vbus_data = {
 	.gpio_vbus = GPIO13_nUSB_DETECT,
 	.gpio_vbus_inverted = 1,
-	.gpio_pullup = -1,
+	.gpio_pullup = GPIO22_USB_ENABLE,
+	.disconnect_on_suspend = 1,
 };
 
 /*
@@ -770,7 +767,6 @@ static void __init mioa701_machine_init(void)
 	pxa_set_fb_info(NULL, &mioa701_pxafb_info);
 	pxa_set_mci_info(&mioa701_mci_info);
 	pxa_set_keypad_info(&mioa701_keypad_info);
-	pxa_set_udc_info(&mioa701_udc_info);
 	pxa_set_ac97_info(&mioa701_ac97_info);
 	pm_power_off = mioa701_poweroff;
 	arm_pm_restart = mioa701_restart;
-- 
1.7.5.4

  parent reply	other threads:[~2011-07-05 13:08 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 13:08 [PATCH 00/15] Big pxa2[57]x_udc cleanup Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 01/15] ARM: pxa/balloon3: drop udc_is_connected Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 02/15] ARM: pxa/mioa701: " Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 03/15] ARM: pxa/stargate2: " Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 04/15] ARM: pxa25x_udc: separate lubbock handling to lubbock-usb transceiver Dmitry Eremin-Solenikov
2011-07-05 13:47   ` Felipe Balbi
2011-07-05 13:08 ` [PATCH 05/15] ARM: pxa/lubbock: switch to using lubbock_usb_xceiv transceiver Dmitry Eremin-Solenikov
2011-07-05 14:47   ` Sergei Shtylyov
2011-07-05 13:08 ` [PATCH 06/15] pxa: drop handling of udc_is_connected Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 07/15] pxa25x_udc: drop support for udc_command Dmitry Eremin-Solenikov
2011-07-05 13:46   ` Felipe Balbi
2011-07-08 21:34     ` Greg KH
2011-07-08 21:54       ` Felipe Balbi
2011-07-08 22:02         ` Greg KH
2011-07-08 22:14           ` Felipe Balbi
2011-07-12 13:41           ` Dmitry Eremin-Solenikov
2011-07-14  2:52             ` Eric Miao
2011-07-14 18:24               ` Robert Jarzmik
2011-07-14 19:01                 ` Robert Jarzmik
2011-07-15 10:40                 ` Eric Miao
2011-07-18  8:38               ` Felipe Balbi
2011-07-09  8:50       ` Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 08/15] otg: add gpio_pullup OTG transceiver for devices with no VBUS sensing Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 09/15] corgi: convert to use gpio-pullup Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 10/15] poodle: " Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 11/15] h5000: " Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 12/15] gpio-vbus: support disabling D+ pullup on suspend Dmitry Eremin-Solenikov
2011-07-05 13:08 ` Dmitry Eremin-Solenikov [this message]
2011-07-05 13:08 ` [PATCH 14/15] gpio-pullup: " Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 15/15] pxa2[57]x_udc: drop gpio_pullup handling Dmitry Eremin-Solenikov
2011-07-05 13:49   ` Felipe Balbi
2011-07-05 20:42   ` Robert Jarzmik
2011-07-05 20:58     ` Dmitry Eremin-Solenikov
2011-07-06  7:20       ` Felipe Balbi
2011-07-06  7:30         ` Dmitry Eremin-Solenikov
2011-07-06  7:34           ` Felipe Balbi
2011-07-05 13:45 ` [PATCH 00/15] Big pxa2[57]x_udc cleanup Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309871321-11305-14-git-send-email-dbaryshkov@gmail.com \
    --to=dbaryshkov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).