From: dbaryshkov@gmail.com (Dmitry Eremin-Solenikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/15] pxa25x_udc: drop support for udc_command
Date: Tue, 5 Jul 2011 17:08:33 +0400 [thread overview]
Message-ID: <1309871321-11305-8-git-send-email-dbaryshkov@gmail.com> (raw)
In-Reply-To: <1309871321-11305-1-git-send-email-dbaryshkov@gmail.com>
None of pxa25x devices use udc_command() for UDC functionality.
Stop calling this callback from pxa25x_udc code.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
drivers/usb/gadget/pxa25x_udc.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c
index 6f543c7..aa34698 100644
--- a/drivers/usb/gadget/pxa25x_udc.c
+++ b/drivers/usb/gadget/pxa25x_udc.c
@@ -144,8 +144,6 @@ static void pullup_off(void)
if (gpio_is_valid(mach->gpio_pullup))
gpio_set_value(mach->gpio_pullup, off_level);
- else if (mach->udc_command)
- mach->udc_command(PXA2XX_UDC_CMD_DISCONNECT);
}
static void pullup_on(void)
@@ -155,8 +153,6 @@ static void pullup_on(void)
if (gpio_is_valid(mach->gpio_pullup))
gpio_set_value(mach->gpio_pullup, on_level);
- else if (mach->udc_command)
- mach->udc_command(PXA2XX_UDC_CMD_CONNECT);
}
static void pio_irq_enable(int bEndpointAddress)
@@ -984,7 +980,7 @@ static int pxa25x_udc_pullup(struct usb_gadget *_gadget, int is_active)
udc = container_of(_gadget, struct pxa25x_udc, gadget);
/* not all boards support pullup control */
- if (!gpio_is_valid(udc->mach->gpio_pullup) && !udc->mach->udc_command)
+ if (!gpio_is_valid(udc->mach->gpio_pullup))
return -EOPNOTSUPP;
udc->pullup = (is_active != 0);
@@ -2241,7 +2237,7 @@ static int pxa25x_udc_suspend(struct platform_device *dev, pm_message_t state)
struct pxa25x_udc *udc = platform_get_drvdata(dev);
unsigned long flags;
- if (!gpio_is_valid(udc->mach->gpio_pullup) && !udc->mach->udc_command)
+ if (!gpio_is_valid(udc->mach->gpio_pullup))
WARNING("USB host won't detect disconnect!\n");
udc->suspended = 1;
--
1.7.5.4
next prev parent reply other threads:[~2011-07-05 13:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 13:08 [PATCH 00/15] Big pxa2[57]x_udc cleanup Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 01/15] ARM: pxa/balloon3: drop udc_is_connected Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 02/15] ARM: pxa/mioa701: " Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 03/15] ARM: pxa/stargate2: " Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 04/15] ARM: pxa25x_udc: separate lubbock handling to lubbock-usb transceiver Dmitry Eremin-Solenikov
2011-07-05 13:47 ` Felipe Balbi
2011-07-05 13:08 ` [PATCH 05/15] ARM: pxa/lubbock: switch to using lubbock_usb_xceiv transceiver Dmitry Eremin-Solenikov
2011-07-05 14:47 ` Sergei Shtylyov
2011-07-05 13:08 ` [PATCH 06/15] pxa: drop handling of udc_is_connected Dmitry Eremin-Solenikov
2011-07-05 13:08 ` Dmitry Eremin-Solenikov [this message]
2011-07-05 13:46 ` [PATCH 07/15] pxa25x_udc: drop support for udc_command Felipe Balbi
2011-07-08 21:34 ` Greg KH
2011-07-08 21:54 ` Felipe Balbi
2011-07-08 22:02 ` Greg KH
2011-07-08 22:14 ` Felipe Balbi
2011-07-12 13:41 ` Dmitry Eremin-Solenikov
2011-07-14 2:52 ` Eric Miao
2011-07-14 18:24 ` Robert Jarzmik
2011-07-14 19:01 ` Robert Jarzmik
2011-07-15 10:40 ` Eric Miao
2011-07-18 8:38 ` Felipe Balbi
2011-07-09 8:50 ` Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 08/15] otg: add gpio_pullup OTG transceiver for devices with no VBUS sensing Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 09/15] corgi: convert to use gpio-pullup Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 10/15] poodle: " Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 11/15] h5000: " Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 12/15] gpio-vbus: support disabling D+ pullup on suspend Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 13/15] mioa701: move gpio-pullup functionality to gpio-vbus Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 14/15] gpio-pullup: support disabling D+ pullup on suspend Dmitry Eremin-Solenikov
2011-07-05 13:08 ` [PATCH 15/15] pxa2[57]x_udc: drop gpio_pullup handling Dmitry Eremin-Solenikov
2011-07-05 13:49 ` Felipe Balbi
2011-07-05 20:42 ` Robert Jarzmik
2011-07-05 20:58 ` Dmitry Eremin-Solenikov
2011-07-06 7:20 ` Felipe Balbi
2011-07-06 7:30 ` Dmitry Eremin-Solenikov
2011-07-06 7:34 ` Felipe Balbi
2011-07-05 13:45 ` [PATCH 00/15] Big pxa2[57]x_udc cleanup Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309871321-11305-8-git-send-email-dbaryshkov@gmail.com \
--to=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).