linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] arm: plat-s3c24xx: dma: don't use uninitialized variable
Date: Thu,  7 Jul 2011 12:18:36 +0200	[thread overview]
Message-ID: <1310033919-4245-2-git-send-email-w.sang@pengutronix.de> (raw)
In-Reply-To: <1310033919-4245-1-git-send-email-w.sang@pengutronix.de>

Commit 8970ef47 (S3C24XX: Remove hardware specific registers from DMA
calls) removed the parameter dcon in s3c2410_dma_config() and calculates
it on its own. So the debug-output for the old parameter can go, too.
Fixes:

arch/arm/plat-s3c24xx/dma.c: In function 's3c2410_dma_config':
arch/arm/plat-s3c24xx/dma.c:1030:2: warning: 'dcon' is used uninitialized in this function

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
---
 arch/arm/plat-s3c24xx/dma.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
index 2abf966..a5b3684 100644
--- a/arch/arm/plat-s3c24xx/dma.c
+++ b/arch/arm/plat-s3c24xx/dma.c
@@ -1027,17 +1027,13 @@ int s3c2410_dma_config(unsigned int channel,
 	struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel);
 	unsigned int dcon;
 
-	pr_debug("%s: chan=%d, xfer_unit=%d, dcon=%08x\n",
-		 __func__, channel, xferunit, dcon);
+	pr_debug("%s: chan=%d, xfer_unit=%d\n", __func__, channel, xferunit);
 
 	if (chan == NULL)
 		return -EINVAL;
 
-	pr_debug("%s: Initial dcon is %08x\n", __func__, dcon);
-
 	dcon = chan->dcon & dma_sel.dcon_mask;
-
-	pr_debug("%s: New dcon is %08x\n", __func__, dcon);
+	pr_debug("%s: dcon is %08x\n", __func__, dcon);
 
 	switch (chan->req_ch) {
 	case DMACH_I2S_IN:
-- 
1.7.5.4

  reply	other threads:[~2011-07-07 10:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 10:18 [PATCH 0/4] Cleanups for the mini2440 board Wolfram Sang
2011-07-07 10:18 ` Wolfram Sang [this message]
2011-07-08  5:38   ` [PATCH 1/4] arm: plat-s3c24xx: dma: don't use uninitialized variable Kukjin Kim
2011-07-07 10:18 ` [PATCH 2/4] arm: plat-s3c24xx: dma: drop return codes in void function Wolfram Sang
2011-07-07 19:51   ` Rafael J. Wysocki
2011-07-08  5:37     ` Kukjin Kim
2011-07-07 10:18 ` [PATCH 3/4] arm: mach-s3c2440: dma: fix section mismatch Wolfram Sang
2011-07-07 10:24   ` Russell King - ARM Linux
2011-07-07 10:33     ` Wolfram Sang
2011-07-07 10:18 ` [PATCH 4/4] arm: mach-s3c2440: mini2440: " Wolfram Sang
2011-07-08  6:06   ` Kukjin Kim
2011-07-08  9:12     ` Russell King - ARM Linux
2011-07-08  9:25       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310033919-4245-2-git-send-email-w.sang@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).