From: haojian.zhuang@marvell.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mmp: add DTS file
Date: Mon, 11 Jul 2011 13:21:09 +0800 [thread overview]
Message-ID: <1310361669.4621.16.camel@Lily> (raw)
In-Reply-To: <20110710073510.GG10912@ponder.secretlab.ca>
On Sun, 2011-07-10 at 00:35 -0700, Grant Likely wrote:
> On Fri, Jul 08, 2011 at 06:20:28PM +0800, Haojian Zhuang wrote:
> > Add DTS file to support brownstone & ttc-dkb.
> >
> > Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
>
> Hi Haojian.
>
> Overall, the patch series is moving in the right direction. I've made
> a lot of comments, but they shouldn't be difficult to resolve. I look
> forward to seeing the next version of the series. Comments below...
>
> > ---
> > arch/arm/boot/dts/mmp2-brownstone.dts | 319 +++++++++++++++++++++++++++++++++
> > arch/arm/boot/dts/ttc-dkb.dts | 176 ++++++++++++++++++
> > arch/arm/mach-mmp/brownstone.c | 66 ++-----
> > arch/arm/mach-mmp/ttc_dkb.c | 21 ++-
> > 4 files changed, 530 insertions(+), 52 deletions(-)
> > create mode 100644 arch/arm/boot/dts/mmp2-brownstone.dts
> > create mode 100644 arch/arm/boot/dts/ttc-dkb.dts
> >
> > diff --git a/arch/arm/boot/dts/mmp2-brownstone.dts b/arch/arm/boot/dts/mmp2-brownstone.dts
> > new file mode 100644
> > index 0000000..5fdabc3
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/mmp2-brownstone.dts
> > @@ -0,0 +1,319 @@
> > +/dts-v1/;
> > +
> > +/include/ "skeleton.dtsi"
> > +
> > + interrupt-controller;
> > + #interrupt-cells = <1>;
> > + sub-interrupts = <64>;
>
> What is this for?
>
Because I need to know how much interrupts could be supported in this
domain? For example, mux4, mux5, ... and supported in mmp2 silicon.
Although they have similar interface, the interrupt numbers are
different in different mux. So I need a property to tell parser that how
much interrupts should be allocated for this interrupt domain.
> > + gpio-controller;
> > + reg = <
> > + 0xd4019000 0xb0
> > + 0xd4019004 0xb0
> > + 0xd4019008 0xb0
> > + 0xd4019100 0xb0
> > + 0xd4019104 0xb0
> > + 0xd4019108 0xb0>;
>
> This looks wrong. The address ranges overlap. Why not simply:
> <0xd4019000 0x200>;
>
These six registers means the start address of six gpio banks. The
registers are overlapped. And internal register of gpio bank are same in
both ARCH-PXA and ARCH-MMP. The only difference is the start register of
each gpio bank.
And there're different gpio numbers in different silicons. If I can
transfer the start gpio address from DTS file, I needn't to hard code
them in gpio driver. If I only write it as <0xd4019000 0x200>, it can't
help driver to understand how much gpio banks existed. Unless I provide
a new property on gpio bank. What's your opinion on this?
next prev parent reply other threads:[~2011-07-11 5:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 10:20 [PATCH] ARM: mmp: remove SPARSE_IRQ for mmp Haojian Zhuang
2011-07-08 10:20 ` [PATCH] ARM: mmp: remove builtin gpio driver support Haojian Zhuang
2011-07-08 10:20 ` [PATCH] ARM: mmp: parse irq from DT Haojian Zhuang
2011-07-08 10:20 ` [PATCH] ARM: mmp: support OF by default Haojian Zhuang
2011-07-08 10:20 ` [PATCH] tty: serial: support device tree in pxa Haojian Zhuang
2011-07-08 10:20 ` [PATCH] tty: serial: check ops before registering console Haojian Zhuang
2011-07-08 10:20 ` [PATCH] i2c: pxa: create dynamic platform device from device tree Haojian Zhuang
2011-07-08 10:20 ` [PATCH] of: add devicetree API for regulator Haojian Zhuang
2011-07-08 10:20 ` [PATCH] regulator: convert devicetree to platform data on max8649 Haojian Zhuang
2011-07-08 10:20 ` [PATCH] mfd: convert devicetree to platform data on max8925 Haojian Zhuang
2011-07-08 10:20 ` [PATCH] mfd: convert devicetree to platform on 88pm860x Haojian Zhuang
2011-07-08 10:20 ` [PATCH] ARM: mmp: add DTS file Haojian Zhuang
2011-07-10 7:35 ` Grant Likely
2011-07-11 5:21 ` Haojian Zhuang [this message]
2011-07-10 7:21 ` [PATCH] mfd: convert devicetree to platform on 88pm860x Grant Likely
2011-07-10 7:20 ` [PATCH] mfd: convert devicetree to platform data on max8925 Grant Likely
2011-07-10 9:17 ` Mark Brown
2011-07-10 10:40 ` Grant Likely
2011-07-08 14:51 ` [PATCH] of: add devicetree API for regulator Grant Likely
2011-07-09 1:14 ` Mark Brown
2011-07-08 18:32 ` Liam Girdwood
2011-07-09 2:03 ` Mark Brown
2011-07-10 5:26 ` [PATCH] i2c: pxa: create dynamic platform device from device tree Grant Likely
2011-07-10 5:11 ` [PATCH] tty: serial: support device tree in pxa Grant Likely
2011-07-10 4:34 ` [PATCH] ARM: mmp: parse irq from DT Grant Likely
2011-07-10 4:02 ` [PATCH] ARM: mmp: remove builtin gpio driver support Grant Likely
2011-07-11 5:05 ` Haojian Zhuang
2011-07-11 11:44 ` Eric Miao
2011-07-08 14:46 ` [PATCH] ARM: mmp: remove SPARSE_IRQ for mmp Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310361669.4621.16.camel@Lily \
--to=haojian.zhuang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).