From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 10/10] ARM: mxs-dma: include <linux/dmaengine.h>
Date: Wed, 20 Jul 2011 11:41:46 +0800 [thread overview]
Message-ID: <1311133306-9496-11-git-send-email-b29396@freescale.com> (raw)
In-Reply-To: <1311133306-9496-1-git-send-email-b29396@freescale.com>
Other files using dma.h may fail to compile as follows:
In file included from sound/soc/mxs/mxs-pcm.h:22,
from sound/soc/mxs/mxs-saif.h:112,
from sound/soc/mxs/mxs-sgtl5000.c:34:
arch/arm/mach-mxs/include/mach/dma.h:16: warning: 'struct dma_chan' declared inside parameter list
arch/arm/mach-mxs/include/mach/dma.h:16: warning: its scope is only this definition or declaration, which is probably not what you want
arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbh':
arch/arm/mach-mxs/include/mach/dma.h:18: error: dereferencing pointer to incomplete type
arch/arm/mach-mxs/include/mach/dma.h: At top level:
arch/arm/mach-mxs/include/mach/dma.h:21: warning: 'struct dma_chan' declared inside parameter list
arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbx':
arch/arm/mach-mxs/include/mach/dma.h:23: error: dereferencing pointer to incomplete type
make[3]: *** [sound/soc/mxs/mxs-sgtl5000.o] Error 1
make[2]: *** [sound/soc/mxs] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2
It seems it's better for dma.h to include dmaengine.h himself.
Signed-off-by: Dong Aisheng <b29396@freescale.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
---
arch/arm/mach-mxs/include/mach/dma.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mxs/include/mach/dma.h b/arch/arm/mach-mxs/include/mach/dma.h
index 7f4aeea..203d7c4 100644
--- a/arch/arm/mach-mxs/include/mach/dma.h
+++ b/arch/arm/mach-mxs/include/mach/dma.h
@@ -9,6 +9,8 @@
#ifndef __MACH_MXS_DMA_H__
#define __MACH_MXS_DMA_H__
+#include <linux/dmaengine.h>
+
struct mxs_dma_data {
int chan_irq;
};
--
1.7.0.4
prev parent reply other threads:[~2011-07-20 3:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 3:41 [PATCH v4 00/10] ARM: mxs: add audio support Dong Aisheng
2011-07-20 3:41 ` [PATCH v4 01/10] ASoc: mxs: add mxs-pcm driver Dong Aisheng
2011-07-20 16:17 ` Liam Girdwood
2011-07-20 16:49 ` [alsa-devel] " Dong Aisheng
2011-07-20 3:41 ` [PATCH v4 02/10] ASoc: mxs: add mxs-saif driver Dong Aisheng
2011-07-20 16:21 ` Liam Girdwood
2011-07-20 16:43 ` [alsa-devel] " Dong Aisheng
2011-07-20 3:41 ` [PATCH v4 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Dong Aisheng
2011-07-20 3:28 ` [alsa-devel] " Tabi Timur-B04825
2011-07-20 3:41 ` [PATCH v4 04/10] ASoc: mxs: add asoc configuration files Dong Aisheng
2011-07-20 3:41 ` [PATCH v4 05/10] ARM: mxs: add saif clock Dong Aisheng
2011-07-20 3:41 ` [PATCH v4 06/10] ARM: mxs: add saif device Dong Aisheng
2011-07-20 3:41 ` [PATCH v4 07/10] ARM: mxs: add sgtl5000 i2c device Dong Aisheng
2011-07-20 3:41 ` [PATCH v4 08/10] ARM: mxs: add mxs-sgtl5000 device Dong Aisheng
2011-07-20 3:41 ` [PATCH v4 09/10] ARM: mxs: correct the using of frac div for saif Dong Aisheng
2011-07-20 3:41 ` Dong Aisheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311133306-9496-11-git-send-email-b29396@freescale.com \
--to=b29396@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).