From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] mtd: dataflash: add device tree probe support
Date: Wed, 20 Jul 2011 07:40:38 +0300 [thread overview]
Message-ID: <1311136844.20738.131.camel@sauron> (raw)
In-Reply-To: <20110715044919.GB1840@S2100-06.ap.freescale.net>
On Fri, 2011-07-15 at 12:49 +0800, Shawn Guo wrote:
> > > +static const struct of_device_id dataflash_dt_ids[] = {
> > > + { .compatible = "atmel,at45xxx", },
> > > + { .compatible = "atmel,dataflash", },
> > > + { /* sentinel */ }
> > > +};
> > > +
> >
> > This should be protected with a #ifdef CONFIG_OF/#else/#endif, and
> > there should be a MODULE_DEVICE_TABLE().
> >
> I personally hate #ifdef stuff. But okay, I can do it since there
> are people being concerned by this little waste of space.
I guess the question is - will it compile and work if CONFIG_OF is
unset?
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-07-20 4:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 7:35 [PATCH] mtd: dataflash: add device tree probe support Shawn Guo
2011-07-14 15:52 ` [PATCH v2] " Shawn Guo
2011-07-14 17:10 ` Mike Frysinger
2011-07-14 17:52 ` Dmitry Eremin-Solenikov
2011-07-15 2:54 ` Grant Likely
2011-07-15 4:42 ` Shawn Guo
2011-07-15 2:54 ` Grant Likely
2011-07-15 4:49 ` Shawn Guo
2011-07-20 4:40 ` Artem Bityutskiy [this message]
2011-07-20 4:55 ` Shawn Guo
2011-07-20 5:17 ` Artem Bityutskiy
2011-07-20 5:28 ` Shawn Guo
2011-07-20 5:32 ` Artem Bityutskiy
2011-07-20 5:38 ` Mike Frysinger
2011-07-20 5:52 ` Shawn Guo
2011-07-20 5:52 ` Artem Bityutskiy
2011-07-15 8:38 ` [PATCH v3] " Shawn Guo
2011-07-20 4:51 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311136844.20738.131.camel@sauron \
--to=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).