* [PATCH] iMX28: Fix emi_ddr_open pinmux
@ 2011-07-21 16:08 Marek Vasut
2011-07-21 19:05 ` Uwe Kleine-König
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2011-07-21 16:08 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
arch/arm/mach-mxs/include/mach/iomux-mx28.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mxs/include/mach/iomux-mx28.h b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
index f50fefd..1a95ecd 100644
--- a/arch/arm/mach-mxs/include/mach/iomux-mx28.h
+++ b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
@@ -203,7 +203,7 @@
#define MX28_PAD_EMI_WEN__EMI_WEN MXS_IOMUX_PAD_NAKED(6, 21, PAD_MUXSEL_0)
#define MX28_PAD_EMI_CE0N__EMI_CE0N MXS_IOMUX_PAD_NAKED(6, 22, PAD_MUXSEL_0)
#define MX28_PAD_EMI_CE1N__EMI_CE1N MXS_IOMUX_PAD_NAKED(6, 23, PAD_MUXSEL_0)
-#define MX28_PAD_EMI_CKE__EMI_CKE MXS_IOMUX_PAD_NAKED(6, 24, PAD_MUXSEL_0)
+#define MX28_PAD_EMI_CKE__EMI_CKE MXS_IOMUX_PAD_NAKED(6, 26, PAD_MUXSEL_0)
/* MUXSEL_1 */
#define MX28_PAD_GPMI_D00__SSP1_D0 MXS_IOMUX_PAD_NAKED(0, 0, PAD_MUXSEL_1)
--
1.7.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] iMX28: Fix emi_ddr_open pinmux
2011-07-21 16:08 [PATCH] iMX28: Fix emi_ddr_open pinmux Marek Vasut
@ 2011-07-21 19:05 ` Uwe Kleine-König
2011-07-21 19:44 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2011-07-21 19:05 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 21, 2011 at 06:08:10PM +0200, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> arch/arm/mach-mxs/include/mach/iomux-mx28.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/include/mach/iomux-mx28.h b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> index f50fefd..1a95ecd 100644
> --- a/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> +++ b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> @@ -203,7 +203,7 @@
> #define MX28_PAD_EMI_WEN__EMI_WEN MXS_IOMUX_PAD_NAKED(6, 21, PAD_MUXSEL_0)
> #define MX28_PAD_EMI_CE0N__EMI_CE0N MXS_IOMUX_PAD_NAKED(6, 22, PAD_MUXSEL_0)
> #define MX28_PAD_EMI_CE1N__EMI_CE1N MXS_IOMUX_PAD_NAKED(6, 23, PAD_MUXSEL_0)
> -#define MX28_PAD_EMI_CKE__EMI_CKE MXS_IOMUX_PAD_NAKED(6, 24, PAD_MUXSEL_0)
> +#define MX28_PAD_EMI_CKE__EMI_CKE MXS_IOMUX_PAD_NAKED(6, 26, PAD_MUXSEL_0)
In my version of the i.MX28 Reference Manual (Rev. 1, 2010) pin24 is
correct. So if you're still convinced that 26 is correct you should point
out in the commit log that the Reference Manual is wrong and why you're
convinced it really is.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] iMX28: Fix emi_ddr_open pinmux
2011-07-21 19:05 ` Uwe Kleine-König
@ 2011-07-21 19:44 ` Marek Vasut
0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2011-07-21 19:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday, July 21, 2011 09:05:36 PM Uwe Kleine-K?nig wrote:
> On Thu, Jul 21, 2011 at 06:08:10PM +0200, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> >
> > arch/arm/mach-mxs/include/mach/iomux-mx28.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> > b/arch/arm/mach-mxs/include/mach/iomux-mx28.h index f50fefd..1a95ecd
> > 100644
> > --- a/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> > +++ b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> > @@ -203,7 +203,7 @@
> >
> > #define MX28_PAD_EMI_WEN__EMI_WEN MXS_IOMUX_PAD_NAKED(6, 21,
> > PAD_MUXSEL_0) #define
> > MX28_PAD_EMI_CE0N__EMI_CE0N MXS_IOMUX_PAD_NAKED(6, 22,
PAD_MUXSEL_0)
> > #define MX28_PAD_EMI_CE1N__EMI_CE1N MXS_IOMUX_PAD_NAKED(6, 23,
> > PAD_MUXSEL_0)
> >
> > -#define MX28_PAD_EMI_CKE__EMI_CKE MXS_IOMUX_PAD_NAKED(6, 24,
> > PAD_MUXSEL_0) +#define
> > MX28_PAD_EMI_CKE__EMI_CKE MXS_IOMUX_PAD_NAKED(6, 26,
PAD_MUXSEL_0)
>
> In my version of the i.MX28 Reference Manual (Rev. 1, 2010) pin24 is
> correct. So if you're still convinced that 26 is correct you should point
> out in the commit log that the Reference Manual is wrong and why you're
> convinced it really is.
Scrap this, you're right.
>
> Best regards
> Uwe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-21 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-21 16:08 [PATCH] iMX28: Fix emi_ddr_open pinmux Marek Vasut
2011-07-21 19:05 ` Uwe Kleine-König
2011-07-21 19:44 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox