* [PATCH] arm64: dts: Fix the value of `dlg,jack-det-rate` mismatch
@ 2024-06-13 10:19 Hsin-Te Yuan
2024-06-13 10:30 ` Heiko Stübner
2024-06-13 10:44 ` AngeloGioacchino Del Regno
0 siblings, 2 replies; 3+ messages in thread
From: Hsin-Te Yuan @ 2024-06-13 10:19 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Heiko Stuebner
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
linux-rockchip, Hsin-Te Yuan
According to Documentation/devicetree/bindings/sound/dialog,da7219.yaml,
the value of `dlg,jack-det-rate` property should be '32_64' instead of
'32ms_64ms'.
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi | 2 +-
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi
index 8b57706ac814..586eee79c73c 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi
@@ -27,7 +27,7 @@ da7219_aad {
dlg,btn-cfg = <50>;
dlg,mic-det-thr = <500>;
dlg,jack-ins-deb = <20>;
- dlg,jack-det-rate = "32ms_64ms";
+ dlg,jack-det-rate = "32_64";
dlg,jack-rem-deb = <1>;
dlg,a-d-btn-thr = <0xa>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
index 789fd0dcc88b..3cd63d1e8f15 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
@@ -450,7 +450,7 @@ da7219_aad {
dlg,btn-cfg = <50>;
dlg,mic-det-thr = <500>;
dlg,jack-ins-deb = <20>;
- dlg,jack-det-rate = "32ms_64ms";
+ dlg,jack-det-rate = "32_64";
dlg,jack-rem-deb = <1>;
dlg,a-d-btn-thr = <0xa>;
---
base-commit: cea2a26553ace13ee36b56dc09ad548b5e6907df
change-id: 20240613-jack-rate-c478fa76ce19
Best regards,
--
Hsin-Te Yuan <yuanhsinte@chromium.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: Fix the value of `dlg,jack-det-rate` mismatch
2024-06-13 10:19 [PATCH] arm64: dts: Fix the value of `dlg,jack-det-rate` mismatch Hsin-Te Yuan
@ 2024-06-13 10:30 ` Heiko Stübner
2024-06-13 10:44 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2024-06-13 10:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Hsin-Te Yuan
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
linux-rockchip, Hsin-Te Yuan
Hi,
Am Donnerstag, 13. Juni 2024, 12:19:58 CEST schrieb Hsin-Te Yuan:
> According to Documentation/devicetree/bindings/sound/dialog,da7219.yaml,
> the value of `dlg,jack-det-rate` property should be '32_64' instead of
> '32ms_64ms'.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 2 +-
sub architectures (Mediatek, Rockchip) are mostly handled by different
people. So it's good to split patches along those lines in the future.
For this change in particular I'm not that concerned in that regard and
am also fine with the Rockchip part going through the Mediatek tree.
I've checked the binding and for the rk3399-gru change:
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Thanks
Heiko
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi
> index 8b57706ac814..586eee79c73c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi
> @@ -27,7 +27,7 @@ da7219_aad {
> dlg,btn-cfg = <50>;
> dlg,mic-det-thr = <500>;
> dlg,jack-ins-deb = <20>;
> - dlg,jack-det-rate = "32ms_64ms";
> + dlg,jack-det-rate = "32_64";
> dlg,jack-rem-deb = <1>;
>
> dlg,a-d-btn-thr = <0xa>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> index 789fd0dcc88b..3cd63d1e8f15 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> @@ -450,7 +450,7 @@ da7219_aad {
> dlg,btn-cfg = <50>;
> dlg,mic-det-thr = <500>;
> dlg,jack-ins-deb = <20>;
> - dlg,jack-det-rate = "32ms_64ms";
> + dlg,jack-det-rate = "32_64";
> dlg,jack-rem-deb = <1>;
>
> dlg,a-d-btn-thr = <0xa>;
>
> ---
> base-commit: cea2a26553ace13ee36b56dc09ad548b5e6907df
> change-id: 20240613-jack-rate-c478fa76ce19
>
> Best regards,
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: Fix the value of `dlg,jack-det-rate` mismatch
2024-06-13 10:19 [PATCH] arm64: dts: Fix the value of `dlg,jack-det-rate` mismatch Hsin-Te Yuan
2024-06-13 10:30 ` Heiko Stübner
@ 2024-06-13 10:44 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-06-13 10:44 UTC (permalink / raw)
To: Hsin-Te Yuan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, Heiko Stuebner
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
linux-rockchip
Il 13/06/24 12:19, Hsin-Te Yuan ha scritto:
> According to Documentation/devicetree/bindings/sound/dialog,da7219.yaml,
> the value of `dlg,jack-det-rate` property should be '32_64' instead of
> '32ms_64ms'.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
Please, two separated commits, one for RockChip, one for MediaTek and
also please add the relevant Fixes tags, so that this can be backported.
arm64: dts: rockchip: rk3399-gru: .....
arm64: dts: mediatek: mt8183-kukui: ....
Thanks,
Angelo
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi
> index 8b57706ac814..586eee79c73c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-audio-da7219.dtsi
> @@ -27,7 +27,7 @@ da7219_aad {
> dlg,btn-cfg = <50>;
> dlg,mic-det-thr = <500>;
> dlg,jack-ins-deb = <20>;
> - dlg,jack-det-rate = "32ms_64ms";
> + dlg,jack-det-rate = "32_64";
> dlg,jack-rem-deb = <1>;
>
> dlg,a-d-btn-thr = <0xa>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> index 789fd0dcc88b..3cd63d1e8f15 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> @@ -450,7 +450,7 @@ da7219_aad {
> dlg,btn-cfg = <50>;
> dlg,mic-det-thr = <500>;
> dlg,jack-ins-deb = <20>;
> - dlg,jack-det-rate = "32ms_64ms";
> + dlg,jack-det-rate = "32_64";
> dlg,jack-rem-deb = <1>;
>
> dlg,a-d-btn-thr = <0xa>;
>
> ---
> base-commit: cea2a26553ace13ee36b56dc09ad548b5e6907df
> change-id: 20240613-jack-rate-c478fa76ce19
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-13 10:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-13 10:19 [PATCH] arm64: dts: Fix the value of `dlg,jack-det-rate` mismatch Hsin-Te Yuan
2024-06-13 10:30 ` Heiko Stübner
2024-06-13 10:44 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).