linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mach-sa1100: fix PCI build problem
@ 2011-08-05 10:24 Linus Walleij
  2011-08-10  7:58 ` Linus Walleij
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2011-08-05 10:24 UTC (permalink / raw)
  To: linux-arm-kernel

The PCI nanoengine driver in the SA1100 machine probably has not
been building for some time. It probably dragged hardware.h
in implicitly and now it doesn't anymore. After this an SA1100
build selecting all system variants will build successfully.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/mach-sa1100/pci-nanoengine.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-sa1100/pci-nanoengine.c b/arch/arm/mach-sa1100/pci-nanoengine.c
index 964c6c3..dd39fee 100644
--- a/arch/arm/mach-sa1100/pci-nanoengine.c
+++ b/arch/arm/mach-sa1100/pci-nanoengine.c
@@ -28,6 +28,7 @@
 #include <asm/mach-types.h>
 
 #include <mach/nanoengine.h>
+#include <mach/hardware.h>
 
 static DEFINE_SPINLOCK(nano_lock);
 
-- 
1.7.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] mach-sa1100: fix PCI build problem
  2011-08-05 10:24 [PATCH] mach-sa1100: fix PCI build problem Linus Walleij
@ 2011-08-10  7:58 ` Linus Walleij
  2011-08-10 16:05   ` Arnd Bergmann
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2011-08-10  7:58 UTC (permalink / raw)
  To: linux-arm-kernel

2011/8/5 Linus Walleij <linus.walleij@linaro.org>:

> The PCI nanoengine driver in the SA1100 machine probably has not
> been building for some time. It probably dragged hardware.h
> in implicitly and now it doesn't anymore. After this an SA1100
> build selecting all system variants will build successfully.

Arnd can you pick this single patch for the -rc series, or do you
prefer pull requests?

Thanks,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] mach-sa1100: fix PCI build problem
  2011-08-10  7:58 ` Linus Walleij
@ 2011-08-10 16:05   ` Arnd Bergmann
  0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2011-08-10 16:05 UTC (permalink / raw)
  To: linux-arm-kernel

On Wednesday 10 August 2011, Linus Walleij wrote:
> 2011/8/5 Linus Walleij <linus.walleij@linaro.org>:
> 
> > The PCI nanoengine driver in the SA1100 machine probably has not
> > been building for some time. It probably dragged hardware.h
> > in implicitly and now it doesn't anymore. After this an SA1100
> > build selecting all system variants will build successfully.
> 
> Arnd can you pick this single patch for the -rc series, or do you
> prefer pull requests?

I've put this one into the fixes branch and will push it to Linus
when that branch has gained critical mass.

I generally prefer git pull requests, but for single patches,
email is absolutely fine and I won't reject patches I get by
email. However, when you want me to apply a patch or git tree,
please always take me on Cc. When you send something only to the
mailing list, I will assume that it's for either review or that
you are sending it to someone else.

To make it less ambiguous, best put me in the 'To' field and the
mailing list on 'Cc' for stuff you want me to apply, or the other
way round for stuff that you want to have reviewed.

	Arnd

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-10 16:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-05 10:24 [PATCH] mach-sa1100: fix PCI build problem Linus Walleij
2011-08-10  7:58 ` Linus Walleij
2011-08-10 16:05   ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).