From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: perf: make name of arm_pmu_type consistent
Date: Wed, 10 Aug 2011 13:58:58 +0100 [thread overview]
Message-ID: <1312981138-17020-2-git-send-email-mark.rutland@arm.com> (raw)
In-Reply-To: <1312981138-17020-1-git-send-email-mark.rutland@arm.com>
Commit f12482c9 ("ARM: 6974/1: pmu: refactor reservation") changed
{release,reserve}_pmu to take an enum arm_pmu_type as a parameter, but
inconsistently named the parameter `type' or `device'. It would be nice
if these were consistent.
This patch makes use of enum arm_pmu_type consistent, always using
'device' as this is more common in usage.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
---
arch/arm/include/asm/pmu.h | 2 +-
arch/arm/kernel/pmu.c | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/include/asm/pmu.h b/arch/arm/include/asm/pmu.h
index 8ae32ba..456117c 100644
--- a/arch/arm/include/asm/pmu.h
+++ b/arch/arm/include/asm/pmu.h
@@ -52,7 +52,7 @@ reserve_pmu(enum arm_pmu_type device);
* a cookie.
*/
extern int
-release_pmu(enum arm_pmu_type type);
+release_pmu(enum arm_pmu_type device);
/**
* init_pmu() - Initialise the PMU.
diff --git a/arch/arm/kernel/pmu.c b/arch/arm/kernel/pmu.c
index 2b70709..89cbdc5 100644
--- a/arch/arm/kernel/pmu.c
+++ b/arch/arm/kernel/pmu.c
@@ -27,22 +27,22 @@ static volatile long pmu_lock;
static struct platform_device *pmu_devices[ARM_NUM_PMU_DEVICES];
static int __devinit pmu_register(struct platform_device *pdev,
- enum arm_pmu_type type)
+ enum arm_pmu_type device)
{
- if (type < 0 || type >= ARM_NUM_PMU_DEVICES) {
+ if (device < 0 || device >= ARM_NUM_PMU_DEVICES) {
pr_warning("received registration request for unknown "
- "device %d\n", type);
+ "device %d\n", device);
return -EINVAL;
}
- if (pmu_devices[type]) {
+ if (pmu_devices[device]) {
pr_warning("rejecting duplicate registration of PMU device "
- "type %d.", type);
+ "type %d.", device);
return -ENOSPC;
}
- pr_info("registered new PMU device of type %d\n", type);
- pmu_devices[type] = pdev;
+ pr_info("registered new PMU device of type %d\n", device);
+ pmu_devices[device] = pdev;
return 0;
}
--
1.7.0.4
next prev parent reply other threads:[~2011-08-10 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 12:58 [PATCH 1/2] ARM: perf: fix prototype of release_pmu Mark Rutland
2011-08-10 12:58 ` Mark Rutland [this message]
2011-08-10 13:05 ` [PATCH 2/2] ARM: perf: make name of arm_pmu_type consistent Will Deacon
2011-08-12 9:06 ` Russell King - ARM Linux
2011-08-12 9:15 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312981138-17020-2-git-send-email-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).