From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c24xx: ensure cpu_reset is only called when memory is flat-mapped
Date: Mon, 15 Aug 2011 18:34:22 +0100 [thread overview]
Message-ID: <1313429662-3145-1-git-send-email-will.deacon@arm.com> (raw)
s3c24xx_pm_restart makes a direct call to arch_reset, without first
establishing a 1:1 memory mapping. arch_reset will then call
cpu_reset(0), which is designed to be called only with an identity map
in place.
Following the discussion here:
http://lists.infradead.org/pipermail/linux-arm-kernel/2011-July/057281.html
This patch ensures that arch_reset is only called via arm_machine_restart
so that we have a consistent flat mapping requirement for the MMU-off
code.
Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
arch/arm/plat-s3c24xx/cpu.c | 12 ------------
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/arch/arm/plat-s3c24xx/cpu.c b/arch/arm/plat-s3c24xx/cpu.c
index c1fc6c6..528930c 100644
--- a/arch/arm/plat-s3c24xx/cpu.c
+++ b/arch/arm/plat-s3c24xx/cpu.c
@@ -198,18 +198,6 @@ static unsigned long s3c24xx_read_idcode_v4(void)
*/
static void s3c24xx_pm_restart(char mode, const char *cmd)
{
- if (mode != 's') {
- unsigned long flags;
-
- local_irq_save(flags);
- __cpuc_flush_kern_all();
- __cpuc_flush_user_all();
-
- arch_reset(mode, cmd);
- local_irq_restore(flags);
- }
-
- /* fallback, or unhandled */
arm_machine_restart(mode, cmd);
}
--
1.7.0.4
next reply other threads:[~2011-08-15 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 17:34 Will Deacon [this message]
2011-08-16 6:46 ` [PATCH] ARM: s3c24xx: ensure cpu_reset is only called when memory is flat-mapped Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313429662-3145-1-git-send-email-will.deacon@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).