From: amit.kachhap@linaro.org (Amit Daniel Kachhap)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/4] ARM: kernel: Small fixes in save/restore common code.
Date: Fri, 19 Aug 2011 18:39:57 +0530 [thread overview]
Message-ID: <1313759400-31347-1-git-send-email-amit.kachhap@linaro.org> (raw)
In-Reply-To: <1313759340-31319-1-git-send-email-amit.kachhap@linaro.org>
These changes are necessary to make the retention cpuidle state work. This adds
support for saving more L2 registers.
Signed-off-by: Amit Daniel Kachhap <amit.kachhap@linaro.org>
---
arch/arm/common/gic.c | 1 -
arch/arm/kernel/sr_helpers.h | 2 +-
arch/arm/mm/cache-l2x0.c | 10 +++++++++-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
index d845b75..124e122 100644
--- a/arch/arm/common/gic.c
+++ b/arch/arm/common/gic.c
@@ -385,7 +385,6 @@ static void gic_dist_save(unsigned int gic_nr)
gic_data[gic_nr].saved_spi_enable[i] =
readl_relaxed(dist_base + GIC_DIST_ENABLE_SET + i * 4);
- writel_relaxed(0, dist_base + GIC_DIST_CTRL);
}
/*
diff --git a/arch/arm/kernel/sr_helpers.h b/arch/arm/kernel/sr_helpers.h
index 1ae3a9a..5a30461 100644
--- a/arch/arm/kernel/sr_helpers.h
+++ b/arch/arm/kernel/sr_helpers.h
@@ -44,7 +44,7 @@ static inline void exit_coherency(void)
"mcr p15, 0, %0, c1, c0, 1\n"
: "=&r" (v)
: "Ir" (0x40)
- : );
+ : "cc");
}
#else
static inline void exit_coherency(void) { }
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index 4c99d41..f23696b 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -285,7 +285,11 @@ static void l2x0_save_context(void *data, bool dormant, unsigned long end)
*l2x0_regs = readl_relaxed(l2x0_base + L2X0_TAG_LATENCY_CTRL);
l2x0_regs++;
*l2x0_regs = readl_relaxed(l2x0_base + L2X0_DATA_LATENCY_CTRL);
-
+ l2x0_regs++;
+ *l2x0_regs = readl_relaxed(l2x0_base + L2X0_PREFETCH_CTRL);
+ l2x0_regs++;
+ *l2x0_regs = readl_relaxed(l2x0_base + L2X0_POWER_CTRL);
+ dormant = 0;
if (!dormant) {
/* clean entire L2 before disabling it*/
writel_relaxed(l2x0_way_mask, l2x0_base + L2X0_CLEAN_WAY);
@@ -325,6 +329,10 @@ static void l2x0_restore_context(void *data, bool dormant)
writel_relaxed(*l2x0_regs, l2x0_base + L2X0_TAG_LATENCY_CTRL);
l2x0_regs++;
writel_relaxed(*l2x0_regs, l2x0_base + L2X0_DATA_LATENCY_CTRL);
+ l2x0_regs++;
+ writel_relaxed(*l2x0_regs, l2x0_base + L2X0_PREFETCH_CTRL);
+ l2x0_regs++;
+ writel_relaxed(*l2x0_regs, l2x0_base + L2X0_POWER_CTRL);
/*
* If L2 is retained do not invalidate
*/
--
1.7.1
next prev parent reply other threads:[~2011-08-19 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 13:09 [RFC PATCH 0/4] ARM: EXYNOS4: Use cpuidle common save/restore framework code Amit Daniel Kachhap
2011-08-19 13:09 ` Amit Daniel Kachhap [this message]
2011-08-19 14:33 ` [RFC PATCH 1/4] ARM: kernel: Small fixes in save/restore common code Amit Kucheria
2011-08-26 15:56 ` Lorenzo Pieralisi
2011-08-19 13:09 ` [RFC PATCH 2/4] ARM: EXYNOS4: Fix to work with origen boards Amit Daniel Kachhap
2011-08-19 13:59 ` Kyungmin Park
2011-08-22 17:01 ` Amit Kachhap
2011-08-19 13:09 ` [RFC PATCH 3/4] ARM: EXYNOS4: Add support AFTR mode cpuidle state on EXYNOS4210 Amit Daniel Kachhap
2011-08-21 17:18 ` Russell King - ARM Linux
2011-08-22 16:55 ` Amit Kachhap
2011-08-19 13:10 ` [RFC PATCH 4/4] ARM: EXYNOS4: Modify cpuidle code to adapt to save/restore common code Amit Daniel Kachhap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313759400-31347-1-git-send-email-amit.kachhap@linaro.org \
--to=amit.kachhap@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).