From: haojian.zhuang@marvell.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 3/3] ARM: pxa/pj4: Port problematic pj4 support code to v7/Thumb-2
Date: Thu, 8 Sep 2011 16:58:41 +0800 [thread overview]
Message-ID: <1315472321.1985.29.camel@Lily> (raw)
In-Reply-To: <52624752.OdLlzNdq0G@wuerfel>
On Wed, 2011-09-07 at 13:27 -0700, Arnd Bergmann wrote:
> On Wednesday 07 September 2011 09:18:15 Eric Miao wrote:
> > > diff --git a/arch/arm/kernel/pj4-cp0.c b/arch/arm/kernel/pj4-cp0.c
> > > index a4b1b07..5117d9d 100644
> > > --- a/arch/arm/kernel/pj4-cp0.c
> > > +++ b/arch/arm/kernel/pj4-cp0.c
> > > @@ -66,9 +66,13 @@ static void __init pj4_cp_access_write(u32 value)
> > >
> > > __asm__ __volatile__ (
> > > "mcr p15, 0, %1, c1, c0, 2\n\t"
> > > +#ifdef __LINUX_ARM_ARCH__ >= 7
> > > + "isb\n\t"
> > > +#else
> > > "mrc p15, 0, %0, c1, c0, 2\n\t"
> > > "mov %0, %0\n\t"
> > > "sub pc, pc, #4\n\t"
> > > +#endif
> >
> > Haojian,
> >
> > Could you check internally if isb() will work here as PJ4 is both v6/v7
> > compatible, and if it's in v7 mode, I guess isb() can be safely used here?
>
PJ4 v6 mode is abandoned in real usage. So we only need to cover v7
mode.
> I thought we only support pj4 in v7 mode in Linux anyway.
>
> Arnd
next prev parent reply other threads:[~2011-09-08 8:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 15:59 [RFC PATCH 0/3] ARM: iwmmxt/pj4 fixes for v7/Thumb-2 Dave Martin
2011-09-07 15:59 ` [RFC PATCH 1/3] ARM: iwmmxt: Fix Makefile rules for building iwmmxt for Thumb-2 Dave Martin
2011-09-07 16:10 ` Eric Miao
2011-09-07 17:18 ` Nicolas Pitre
2011-09-07 20:32 ` Arnd Bergmann
2011-09-08 8:53 ` Dave Martin
2011-09-07 15:59 ` [RFC PATCH 2/3] ARM: iwmmxt: Port problematic iwmmxt support code to v7/Thumb-2 Dave Martin
2011-09-07 16:13 ` Eric Miao
2011-09-07 20:35 ` Arnd Bergmann
2011-09-08 8:58 ` Dave Martin
2011-09-08 9:01 ` Russell King - ARM Linux
2011-09-08 11:33 ` Dave Martin
2011-09-08 14:40 ` Arnd Bergmann
2011-09-07 15:59 ` [RFC PATCH 3/3] ARM: pxa/pj4: Port problematic pj4 " Dave Martin
2011-09-07 16:18 ` Eric Miao
2011-09-07 20:27 ` Arnd Bergmann
2011-09-08 8:58 ` Haojian Zhuang [this message]
2011-09-08 11:10 ` Sergei Shtylyov
2011-09-08 11:35 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315472321.1985.29.camel@Lily \
--to=haojian.zhuang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).